Questions about monitoring app/plugins

[David Jencks <da...@yahoo.com>]

I was having some mysterious build problems and happened to look at  
the monitoring app today a bit (plugins/monitoring).  I'm a bit  
confused by the structure and wonder if it could be simplified.

My impression is that there are two versions of an agent and a web app.

agent:
common jar
datasource
ejb app
jmx jar

The ejb app appears to be wrapped in an ear.  Why?  I can't see any  
reason for this
the jmx jar doesn't appear to be looking up the right thing in jndi.   
See http://cwiki.apache.org/confluence/display/GMOxDOC21/JNDI   
geronimo-connector should not be needed here.

monitoring app:
Here there appears to be a war inside an ear for no apparent reason.

Could someone who has worked on this in the past comment?

thanks
david jencks

Re: Questions about monitoring app/plugins

[David Jencks <da...@yahoo.com>]

On May 13, 2008, at 6:36 PM, Viet Nguyen wrote:

> Hi David,
>
> You are right about not needing to wrap the ejb app inside an EAR. I
> think your patch attached with geronimo-4014 looks great.

It looks ok to me too but I'm not sure how to tell how much it  
breaks.  I'll try to simplify a bit more, perhaps one of the experts  
here could check for breakage before I commit?
>
>
> Regarding the JNDI look up in the jmx-jar, I resorted to using
> something like "jca:/org.apache.geronimo.plugins/agent-ds/ 
> JCAManagedConnectionFactory/jdbc/ActiveDS"
> because of the discussion taken place here:
> http://www.nabble.com/how-to-get-Datasource-from-a-non-j2ee-module-td15081831s134.html
>
> It also looks be to consistent with the format given on the wiki.
> Which JNDI string do you see a problem with?

The string looks ok, but I think you get the DataSource from the jndi  
lookup, not the gbean itself.  This is a new feature in 2.1.  I'd  
expect rather than this:

             activeDS = (DataSource) 
((ManagedConnectionFactoryWrapper)ic.lookup("jca:/ 
org.apache.geronimo.plugins/agent-ds/JCAManagedConnectionFactory/jdbc/ 
ActiveDS")).$getResource();


we'd want this:
             activeDS = (DataSource)ic.lookup("jca:/ 
org.apache.geronimo.plugins/agent-ds/JCAManagedConnectionFactory/jdbc/ 
ActiveDS");

look for a new patch :-)
thanks
david jencks

>
>
> Thanks,
> Viet

Re: Questions about monitoring app/plugins

[Viet Nguyen <vh...@gmail.com>]

Hi David,

You are right about not needing to wrap the ejb app inside an EAR. I
think your patch attached with geronimo-4014 looks great.

Regarding the JNDI look up in the jmx-jar, I resorted to using
something like "jca:/org.apache.geronimo.plugins/agent-ds/JCAManagedConnectionFactory/jdbc/ActiveDS"
because of the discussion taken place here:
http://www.nabble.com/how-to-get-Datasource-from-a-non-j2ee-module-td15081831s134.html

It also looks be to consistent with the format given on the wiki.
Which JNDI string do you see a problem with?

Thanks,
Viet

Re: Questions about monitoring app/plugins

[David Jencks <da...@yahoo.com>]

I opened GERONIMO-4014 and attached a suggestion about how to remove  
one of the ears that don't look necessary to me.

thanks
david jencks

On May 13, 2008, at 4:48 PM, David Jencks wrote:

> I was having some mysterious build problems and happened to look at  
> the monitoring app today a bit (plugins/monitoring).  I'm a bit  
> confused by the structure and wonder if it could be simplified.
>
> My impression is that there are two versions of an agent and a web  
> app.
>
> agent:
> common jar
> datasource
> ejb app
> jmx jar
>
> The ejb app appears to be wrapped in an ear.  Why?  I can't see any  
> reason for this
> the jmx jar doesn't appear to be looking up the right thing in  
> jndi.  See http://cwiki.apache.org/confluence/display/GMOxDOC21/ 
> JNDI  geronimo-connector should not be needed here.
>
> monitoring app:
> Here there appears to be a war inside an ear for no apparent reason.
>
> Could someone who has worked on this in the past comment?
>
> thanks
> david jencks
>