You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2022/04/20 05:54:09 UTC
[dubbo-go] branch 3.0 updated: Add req.Data to OnMessage panic error log (#1847)
This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
The following commit(s) were added to refs/heads/3.0 by this push:
new 3be2d9806 Add req.Data to OnMessage panic error log (#1847)
3be2d9806 is described below
commit 3be2d98061f80c18975289c7694f194aa6b5f2b7
Author: shenchao861129 <sh...@qq.com>
AuthorDate: Wed Apr 20 13:54:03 2022 +0800
Add req.Data to OnMessage panic error log (#1847)
Co-authored-by: shenchao <sh...@zongheng.com>
---
remoting/getty/listener.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/remoting/getty/listener.go b/remoting/getty/listener.go
index c79f24299..f9d510766 100644
--- a/remoting/getty/listener.go
+++ b/remoting/getty/listener.go
@@ -269,13 +269,13 @@ func (h *RpcServerHandler) OnMessage(session getty.Session, pkg interface{}) {
if e := recover(); e != nil {
resp.Status = hessian.Response_SERVER_ERROR
if err, ok := e.(error); ok {
- logger.Errorf("OnMessage panic: %+v", perrors.WithStack(err))
+ logger.Errorf("OnMessage panic: %+v, req: %#v", perrors.WithStack(err), req.Data)
resp.Error = perrors.WithStack(err)
} else if err, ok := e.(string); ok {
- logger.Errorf("OnMessage panic: %+v", perrors.New(err))
+ logger.Errorf("OnMessage panic: %+v, req: %#v", perrors.New(err), req.Data)
resp.Error = perrors.New(err)
} else {
- logger.Errorf("OnMessage panic: %+v, this is impossible.", e)
+ logger.Errorf("OnMessage panic: %+v, this is impossible. req: %#v", e, req.Data)
resp.Error = fmt.Errorf("OnMessage panic unknow exception. %+v", e)
}