You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2009/09/19 01:13:44 UTC

[PATCH] Add support for Berkeley DB 4.8

I'm attaching the patch which adds support for Berkeley DB 4.8. The patch
should be applied to APR trunk (2.0) and 1.4.x and 1.3.x branches of APR-Util.

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Add support for Berkeley DB 4.8

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2009-09-19 01:52:35 Neil Conway napisaƂ(a):
> On Fri, Sep 18, 2009 at 4:13 PM, Arfrever Frehtes Taifersar Arahesis
> <ar...@gmail.com> wrote:
> > I'm attaching the patch which adds support for Berkeley DB 4.8. The patch
> > should be applied to APR trunk (2.0) and 1.4.x and 1.3.x branches of APR-Util.
> 
> I notice that the configure support for DB 4.0, 4.1, and 4.2 checks
> under /usr/local by default, e.g.
> 
>     places="std /usr/local /usr/local/BerkeleyDB.4.2 /boot/home/config"
> 
> whereas support for DB >= 4.3 does not, e.g.
> 
>     places="std /usr/local/BerkeleyDB.4.3 /boot/home/config"
> 
> Is there a rationale for this inconsistency?

You should ask a person who added support for >=4.3 :) .
I simply copied 4.7-related code and replaced "7" with "8".

I have also successfully rebuilt Subversion with Berkeley DB 4.8 and run
Subversion tests. All tests passed.

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Add support for Berkeley DB 4.8

Posted by Nick Kew <ni...@apache.org>.
On 19 Sep 2009, at 00:52, Neil Conway wrote:

> On Fri, Sep 18, 2009 at 4:13 PM, Arfrever Frehtes Taifersar Arahesis
> <ar...@gmail.com> wrote:
>> I'm attaching the patch which adds support for Berkeley DB 4.8.  
>> The patch
>> should be applied to APR trunk (2.0) and 1.4.x and 1.3.x branches  
>> of APR-Util.
>
> I notice that the configure support for DB 4.0, 4.1, and 4.2 checks
> under /usr/local by default, e.g.
>
>     places="std /usr/local /usr/local/BerkeleyDB.4.2 /boot/home/ 
> config"
>
> whereas support for DB >= 4.3 does not, e.g.
>
>     places="std /usr/local/BerkeleyDB.4.3 /boot/home/config"
>
> Is there a rationale for this inconsistency?

Probably a bugfix.  ISTR some problems with detection getting seriously
tied up in knots around the time of 4.0/4.1.

The svn logs *should* give a hint to the motivation of the change.

-- 
Nick Kew


Re: [PATCH] Add support for Berkeley DB 4.8

Posted by Neil Conway <nr...@cs.berkeley.edu>.
On Fri, Sep 18, 2009 at 4:13 PM, Arfrever Frehtes Taifersar Arahesis
<ar...@gmail.com> wrote:
> I'm attaching the patch which adds support for Berkeley DB 4.8. The patch
> should be applied to APR trunk (2.0) and 1.4.x and 1.3.x branches of APR-Util.

I notice that the configure support for DB 4.0, 4.1, and 4.2 checks
under /usr/local by default, e.g.

    places="std /usr/local /usr/local/BerkeleyDB.4.2 /boot/home/config"

whereas support for DB >= 4.3 does not, e.g.

    places="std /usr/local/BerkeleyDB.4.3 /boot/home/config"

Is there a rationale for this inconsistency?

Otherwise, patch looks good, +1 from me.

Neil

Re: [PATCH] Add support for Berkeley DB 4.8

Posted by Graham Leggett <mi...@sharp.fm>.
Arfrever Frehtes Taifersar Arahesis wrote:

> I'm attaching the patch which adds support for Berkeley DB 4.8. The patch
> should be applied to APR trunk (2.0) and 1.4.x and 1.3.x branches of APR-Util.

Thanks for this. Committed to apr-trunk, and backported to apr-util v1.4
and v1.3.

Regards,
Graham
--