You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/08 19:07:08 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #23726: added comments for tensorflow notebook

damccorm commented on code in PR #23726:
URL: https://github.com/apache/beam/pull/23726#discussion_r1017016075


##########
examples/notebooks/beam-ml/run_inference_tensorflow.ipynb:
##########
@@ -414,6 +413,8 @@
         "'x': tf.io.FixedLenFeature([], tf.float32),\n",
         "}\n",
         "\n",
+        "# tf.function compiles the function into a callable TF graph.\n",
+        "# RunInference relies on calling a TF graph as a model.\n",

Review Comment:
   @ryanthompson591 reminder about this lingering comment. Once that is in we can merge



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org