You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/02 14:51:22 UTC
[GitHub] [spark] huaxingao opened a new pull request #34469: Support drop index
huaxingao opened a new pull request #34469:
URL: https://github.com/apache/spark/pull/34469
### What changes were proposed in this pull request?
add drop index syntax
```
DROP INDEX [IF EXISTS] index_name ON [TABLE] table_name
```
### Why are the changes needed?
so user can drop index using sql
### Does this PR introduce _any_ user-facing change?
yes
new sql syntax `DROP INDEX [IF EXISTS] index_name ON [TABLE] table_name`
### How was this patch tested?
new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958023909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49326/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958026676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34469:
URL: https://github.com/apache/spark/pull/34469#discussion_r741536151
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala
##########
@@ -162,9 +162,26 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationSuite with V2JDBCTest {
assert(jdbcTable.indexExists("i1") == true)
assert(jdbcTable.indexExists("i2") == true)
+ // This should pass without Exception
Review comment:
nit: `Exception` -> `exception`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropIndexExec.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.NoSuchIndexException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.index.SupportsIndex
+
+/**
+ * Physical plan node for dropping an index.
+ */
+case class DropIndexExec(
+ table: SupportsIndex,
+ indexName: String,
+ ignoreIfNotExists: Boolean) extends LeafV2CommandExec {
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ table.dropIndex(indexName)
+ } catch {
+ case _: NoSuchIndexException if ignoreIfNotExists =>
+ logWarning(s"Index $indexName not exists. Ignoring.")
Review comment:
nit: `not exists` -> `does not exist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34469:
URL: https://github.com/apache/spark/pull/34469#discussion_r741544276
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2300,6 +2300,11 @@ class DDLParserSuite extends AnalysisTest {
.zip(Seq(Map("k1" -> "v1"), Map("k2" -> "v2"))), Map("k3" -> "v3", "k4" -> "v4")))
}
+ test("DROP INDEX") {
+ parseCompare("DROP index i1 ON a.b.c",
+ DropIndex(UnresolvedTable(Seq("a", "b", "c"), "DROP INDEX", None), "i1", false))
+ }
Review comment:
Can you add another "IF EXISTS" case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #34469:
URL: https://github.com/apache/spark/pull/34469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958144952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49327/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958420429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958681414
Merged to master. Thanks for reviewing! @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958026676
**[Test build #144857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144857/testReport)** for PR 34469 at commit [`56299c1`](https://github.com/apache/spark/commit/56299c1ba0553ca528d0b2b68ec40dd10fee55f1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958596464
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848
**[Test build #144865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit [`5229889`](https://github.com/apache/spark/commit/52298892485939d06e8edcb748f51e98b58ecf91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958685602
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958023909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49326/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34469:
URL: https://github.com/apache/spark/pull/34469#discussion_r741536151
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala
##########
@@ -162,9 +162,26 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationSuite with V2JDBCTest {
assert(jdbcTable.indexExists("i1") == true)
assert(jdbcTable.indexExists("i2") == true)
+ // This should pass without Exception
Review comment:
nit: `Exception` -> `exception`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropIndexExec.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.NoSuchIndexException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.index.SupportsIndex
+
+/**
+ * Physical plan node for dropping an index.
+ */
+case class DropIndexExec(
+ table: SupportsIndex,
+ indexName: String,
+ ignoreIfNotExists: Boolean) extends LeafV2CommandExec {
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ table.dropIndex(indexName)
+ } catch {
+ case _: NoSuchIndexException if ignoreIfNotExists =>
+ logWarning(s"Index $indexName not exists. Ignoring.")
Review comment:
nit: `not exists` -> `does not exist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957902710
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49320/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958681414
Merged to master. Thanks for reviewing! @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958094271
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49327/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848
**[Test build #144865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit [`5229889`](https://github.com/apache/spark/commit/52298892485939d06e8edcb748f51e98b58ecf91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958584621
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848
**[Test build #144865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit [`5229889`](https://github.com/apache/spark/commit/52298892485939d06e8edcb748f51e98b58ecf91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958415944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #34469:
URL: https://github.com/apache/spark/pull/34469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958420429
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #34469:
URL: https://github.com/apache/spark/pull/34469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848
**[Test build #144865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit [`5229889`](https://github.com/apache/spark/commit/52298892485939d06e8edcb748f51e98b58ecf91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958420429
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34469:
URL: https://github.com/apache/spark/pull/34469#discussion_r741544276
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2300,6 +2300,11 @@ class DDLParserSuite extends AnalysisTest {
.zip(Seq(Map("k1" -> "v1"), Map("k2" -> "v2"))), Map("k3" -> "v3", "k4" -> "v4")))
}
+ test("DROP INDEX") {
+ parseCompare("DROP index i1 ON a.b.c",
+ DropIndex(UnresolvedTable(Seq("a", "b", "c"), "DROP INDEX", None), "i1", false))
+ }
Review comment:
Can you add another "IF EXISTS" case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957954933
**[Test build #144850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://github.com/apache/spark/commit/dc97485a9bfc10f3be7e76a13bedab5f4365f506).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958172391
Don't we need JIRA number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958180701
Added Jira number. @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958134786
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49327/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958681414
Merged to master. Thanks for reviewing! @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
**[Test build #144850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://github.com/apache/spark/commit/dc97485a9bfc10f3be7e76a13bedab5f4365f506).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958026676
**[Test build #144857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144857/testReport)** for PR 34469 at commit [`56299c1`](https://github.com/apache/spark/commit/56299c1ba0553ca528d0b2b68ec40dd10fee55f1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957974156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958675839
**[Test build #144865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit [`5229889`](https://github.com/apache/spark/commit/52298892485939d06e8edcb748f51e98b58ecf91).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
**[Test build #144850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://github.com/apache/spark/commit/dc97485a9bfc10f3be7e76a13bedab5f4365f506).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958415944
**[Test build #144857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144857/testReport)** for PR 34469 at commit [`56299c1`](https://github.com/apache/spark/commit/56299c1ba0553ca528d0b2b68ec40dd10fee55f1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957942782
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49320/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958144952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49327/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: Support drop index
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958165460
cc @sunchao @viirya @dbtsai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958685602
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958681414
Merged to master. Thanks for reviewing! @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958420429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34469:
URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org