[GitHub] [cordova-plugin-file] GitToTheHub opened a new issue #507: Resolve URLs with more than one colon fails

[GitBox <gi...@apache.org>]

GitToTheHub opened a new issue #507:
URL: https://github.com/apache/cordova-plugin-file/issues/507


   # Bug Report
   If I try to resolve something like `http://localhost:8000/index.html` i get an `ENCODING_ERR` because of these lines:
   https://github.com/apache/cordova-plugin-file/blob/3e588763a5e49ea441a996bf4139efdf6f6a5f11/www/resolveLocalFileSystemURI.js#L55-L62
   
   When i disable this code like i did here https://github.com/GitToTheHub/cordova-plugin-file/pull/1, I can finally resolve urls like `http://localhost:8000/index.html`. Do someone know why these lines of code exist and if it's safe to remove them? I would make an PR without these lines, or by allowing maximum 2 colons.
   
   ## Problem
   
   ### What is expected to happen?
   
   URLs like `http://localhost:8000/index.html` should resolve
   
   ### What does actually happen?
   
   The API throws `ENCODING_ERR`
   
   ## Information
   Just run the app in a browser and try to resolve `http://localhost:8000/index.html`.
   
   ### Command or Code
   ```
   resolveLocalFileSystemURL(
     "http://localhost:8000/index.html",
     (fileEntry) => {
       alert("URL successfully resolved! name=" + fileEntry.name);
     },
     (fileError) => {
       alert("URL could not be resolved: " + fileError.code);
     }
   );
   
   (Something to note: When i try to resolve a wrong url with my changed code, to allow more than one colon, the errorcallback will not be invoked)
   ```
   
   ### Environment, Platform, Device
   Browser platform, but this issue will occure in any other platform also.
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org