[GitHub] [commons-imaging] mureinik opened a new pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter

[GitBox <gi...@apache.org>]

mureinik opened a new pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter
URL: https://github.com/apache/commons-imaging/pull/61
 
 
   This PR follows up https://github.com/apache/commons-imaging/pull/59 and completes the migration to JUnit Jupiter:
   
   - Usages of `org.junit.Assert.assert[Not]Null` were replaced with `org.junit.jupiter.api.Assertions.asserrt[Not]Null`.
   - Usages of `@Theories` and `@DataPoints` where replaces with JUnit Jupiter's `@ParameterizedTest` with `@MethodSources`. Unfortunately, Jupiter doesn't have a built-in capability to create a Cartesian product of datapoints like `@Theories` does, so this logic had to be explicitly implemented in `RountripBase`.
   - With this cleanup, the additional Junit 5 Vintage dependencies could be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services