You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/02 08:53:57 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #3148: Library to process Heap dumps without accessing java.io.File
sdedic commented on a change in pull request #3148:
URL: https://github.com/apache/netbeans/pull/3148#discussion_r700841514
##########
File path: profiler/lib.profiler/src/org/netbeans/lib/profiler/heap/HprofHeap.java
##########
@@ -146,6 +147,23 @@
heapDumpFile = dumpFile;
}
+ HprofHeap(ByteBuffer bb, int seg, CacheDirectory cacheDir) throws IOException {
Review comment:
Is it possible to mak a common private constructor with a ByteBuffer and an optional File ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists