You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mariusz Górski <go...@gmail.com> on 2020/12/29 21:09:05 UTC

Review Request 73112: ATLAS-4090 - Circular Imports Fix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73112/
-----------------------------------------------------------

Review request for atlas and Verdan Mahmood.


Repository: atlas


Description
-------

Fix circular imports due to codependency between glossary and instance models


Diffs
-----

  intg/src/main/python/apache_atlas/model/instance.py 707d5bbe4 


Diff: https://reviews.apache.org/r/73112/diff/1/


Testing
-------


Thanks,

Mariusz Górski


Re: Review Request 73112: ATLAS-4090 - Circular Imports Fix

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73112/#review222394
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 29, 2020, 9:36 p.m., Mariusz Górski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73112/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2020, 9:36 p.m.)
> 
> 
> Review request for atlas and Verdan Mahmood.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fix circular imports due to codependency between glossary and instance models
> 
> 
> Diffs
> -----
> 
>   intg/src/main/python/README.md a97371762 
>   intg/src/main/python/apache_atlas/model/instance.py 707d5bbe4 
> 
> 
> Diff: https://reviews.apache.org/r/73112/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>


Re: Review Request 73112: ATLAS-4090 - Circular Imports Fix

Posted by Mariusz Górski <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73112/
-----------------------------------------------------------

(Updated Dec. 29, 2020, 9:36 p.m.)


Review request for atlas and Verdan Mahmood.


Changes
-------

change after running sample README.md script


Repository: atlas


Description
-------

Fix circular imports due to codependency between glossary and instance models


Diffs (updated)
-----

  intg/src/main/python/README.md a97371762 
  intg/src/main/python/apache_atlas/model/instance.py 707d5bbe4 


Diff: https://reviews.apache.org/r/73112/diff/2/

Changes: https://reviews.apache.org/r/73112/diff/1-2/


Testing
-------


Thanks,

Mariusz Górski