You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/01/23 00:28:05 UTC

[GitHub] WillemJiang commented on a change in pull request #392: [SCB-1127] Support alpha server registering to Spring Cloud Eureka

WillemJiang commented on a change in pull request #392: [SCB-1127] Support alpha server registering to Spring Cloud Eureka
URL: https://github.com/apache/servicecomb-pack/pull/392#discussion_r250014670
 
 

 ##########
 File path: alpha/alpha-server/pom.xml
 ##########
 @@ -162,6 +162,14 @@
       <groupId>io.netty</groupId>
       <artifactId>netty-tcnative-boringssl-static</artifactId>
     </dependency>
+
+    <!-- spring cloud -->
+    <dependency>
+      <groupId>org.springframework.cloud</groupId>
+      <artifactId>spring-cloud-starter-netflix-eureka-client</artifactId>
 
 Review comment:
   I think we may consider to use consul instead of eureka by default.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services