[GitHub] soeque1 edited a comment on issue #12778: Cannot print parameter summary of embedding layer

[GitBox <gi...@apache.org>]

soeque1 edited a comment on issue #12778: Cannot print parameter summary of embedding layer 
URL: https://github.com/apache/incubator-mxnet/issues/12778#issuecomment-428455018
 
 
   https://github.com/chinakook/mxnet/blob/50f0c4ccf3ebcf1d9f014f39b67dd4c8f28eda80/python/mxnet/visualization.py
   
   It seems that the Embedding layers is currently missing. 
   So It needs to be added at Line 162 as below.
   
   ```
   elif op == 'Embedding':
       key = node["name"].replace("fwd", "weight")
       if show_shape:
           cur_param = shape_dict[key][0] * shape_dict[key][1]
   ````

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services