You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by SuJinpei <gi...@git.apache.org> on 2018/02/01 07:14:30 UTC
[GitHub] trafodion pull request #1433: [TRAFODION-2939] odb copied data exceeds the m...
GitHub user SuJinpei opened a pull request:
https://github.com/apache/trafodion/pull/1433
[TRAFODION-2939] odb copied data exceeds the max size specified by max option when copying data from oracle to Trafodion
**root cause:** max rows were divided into each thread may cause etab[eid].mr < etab[eid].r, so even only one-time fetch, the actual fetched rows will exceed max row of each thread.
**fixed by:** limit etab[eid].r less or equal to etab[eid].mr.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SuJinpei/incubator-trafodion trafodion-2939
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1433
----
commit 0d6ce6f6904f1e528e5502bbd51c013be573e6e9
Author: SuJinpei <87...@...>
Date: 2018-02-01T06:57:23Z
fix trafodion-2939
commit 5cd19f67339ed8a3595266cc6ac921a476b7c647
Author: SuJinpei <87...@...>
Date: 2018-02-01T07:03:08Z
little improvement
----
---
[GitHub] trafodion pull request #1433: [TRAFODION-2939] odb copied data exceeds the m...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1433#discussion_r165525730
--- Diff: core/conn/odb/src/odb.c ---
@@ -5491,9 +5491,11 @@ static void etabadd(char type, char *run, int id)
}
} else { /* not a load job */
etab[no].k = no; /* record grandparent for copy/diff ops */
- if ( etab[no].ps ){
+ if ( etab[no].ps > 1 ){
--- End diff --
Can you please explain why we don't need this IF block when etab[no].ps =1 ? Is it it because for a extract/copy when we have one stream comparing rowset size to max number of rows is done elsewhere in this file?
---
[GitHub] trafodion pull request #1433: [TRAFODION-2939] odb copied data exceeds the m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1433
---