[jira] [Commented] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline

["Thomas Groh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770573#comment-15770573 ] 

Thomas Groh commented on BEAM-1205:
-----------------------------------

I really like this idea, but there are a couple of things we should make sure we understand before making this change.

Within the core SDK, this will remove some fiddlyness of using {{TestPipeline}} for construction-based tests. However, we don't expect users to annotate their tests with {{RunnableOnService}}, so setting to false if the annotation is not present is not idea. Instead, we can do something with checking to see if the current runner is {{CrashingRunner}}, and check that the package prefix is {{org.apache.beam}} (which, admittedly, is somewhat fragile; I'd love other ideas). This might require a little more investigation.

> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>
>                 Key: BEAM-1205
>                 URL: https://issues.apache.org/jira/browse/BEAM-1205
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} annotation, the presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} is present on a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)