You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/04/15 04:53:06 UTC

[GitHub] [samza] Sanil15 commented on a change in pull request #1347: SAMZA-2511 : Adding logic to handle container stop fail

Sanil15 commented on a change in pull request #1347: SAMZA-2511 : Adding logic to handle container stop fail 
URL: https://github.com/apache/samza/pull/1347#discussion_r408576566
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
 ##########
 @@ -233,6 +233,30 @@ void handleContainerLaunchFail(String processorId, String containerId, String pr
     }
   }
 
+  /**
+   * Handle the container stop failure for active containers and standby (if enabled).
+   * @param processorId logical id of the container eg 1,2,3
+   * @param containerId last known id of the container deployed
+   * @param containerHost host on which container is requested to be deployed
+   * @param containerAllocator allocator for requesting resources
+   */
+  void handleContainerStopFail(String processorId, String containerId, String containerHost,
+      ContainerAllocator containerAllocator) {
+    if (processorId != null && hasActiveContainerPlacementAction(processorId)) {
+      // Assuming resource acquired on destination host will be relinquished by the containerAllocator,
 
 Review comment:
   ContainerAllocator only relinquishes resources when there are no requests in the queue. It will be worth manually releasing the resource in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services