You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yevgenypats (via GitHub)" <gi...@apache.org> on 2023/03/26 19:09:42 UTC
[GitHub] [arrow] yevgenypats opened a new pull request, #34734: [GH-34657]: [Go] Move Scalar interface to arrow
yevgenypats opened a new pull request, #34734:
URL: https://github.com/apache/arrow/pull/34734
This is a pre-requirement for https://github.com/apache/arrow/issues/34657 as array interface needs access to the Scalar interface and without it, it will cause cyclic loop.
cc @zeroshade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #34734: GH-34657: [Go] Move Scalar interface to arrow
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #34734:
URL: https://github.com/apache/arrow/pull/34734#issuecomment-1492555429
I don't think this resolves the issue unfortunately, which is why the existing `GetScalar` method is in the Scalar package. Even if you put the `Scalar` interface into the `arrow` package, if you try to put `GetScalar` as a member of the `Array` objects you'll still run into the issue of trying to actually construct your `Scalar` objects. You'll still run into the cyclical import if you try to call any of the `MakeScalar` methods. So I don't think that this is really worthwhile since it doesn't solve the cyclical import problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] yevgenypats closed pull request #34734: GH-34657: [Go] Move Scalar interface to arrow
Posted by "yevgenypats (via GitHub)" <gi...@apache.org>.
yevgenypats closed pull request #34734: GH-34657: [Go] Move Scalar interface to arrow
URL: https://github.com/apache/arrow/pull/34734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34734: GH-34657: [Go] Move Scalar interface to arrow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34734:
URL: https://github.com/apache/arrow/pull/34734#issuecomment-1492548727
* Closes: #34657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34734: [GH-34657]: [Go] Move Scalar interface to arrow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34734:
URL: https://github.com/apache/arrow/pull/34734#issuecomment-1484194470
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34734: GH-34657: [Go] Move Scalar interface to arrow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34734:
URL: https://github.com/apache/arrow/pull/34734#issuecomment-1492548776
:warning: GitHub issue #34657 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org