You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2017/04/20 01:10:15 UTC
jclouds git commit: JCLOUDS-1271: Deprecate signRemoveBlob
Repository: jclouds
Updated Branches:
refs/heads/master f0e11d5c2 -> 2e7de9f85
JCLOUDS-1271: Deprecate signRemoveBlob
URL signing should always use authentication parameters instead of
headers yet no provider supports DELETEs with the former.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/2e7de9f8
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/2e7de9f8
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/2e7de9f8
Branch: refs/heads/master
Commit: 2e7de9f850bfc699ccd4df313c3dfe42be87f501
Parents: f0e11d5
Author: Andrew Gaul <ga...@apache.org>
Authored: Wed Apr 19 18:08:52 2017 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Wed Apr 19 18:08:52 2017 -0700
----------------------------------------------------------------------
.../java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java | 1 +
.../swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java | 1 +
.../src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java | 1 +
.../src/main/java/org/jclouds/blobstore/BlobRequestSigner.java | 1 +
.../src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java | 1 +
.../org/jclouds/blobstore/internal/RequestSigningUnsupported.java | 1 +
.../org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java | 1 +
7 files changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/apis/atmos/src/main/java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/apis/atmos/src/main/java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java b/apis/atmos/src/main/java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java
index 8563222..0d9b5c6 100644
--- a/apis/atmos/src/main/java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java
+++ b/apis/atmos/src/main/java/org/jclouds/atmos/blobstore/AtmosBlobRequestSigner.java
@@ -85,6 +85,7 @@ public class AtmosBlobRequestSigner implements BlobRequestSigner {
throw new UnsupportedOperationException();
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
checkNotNull(container, "container");
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java
----------------------------------------------------------------------
diff --git a/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java b/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java
index 5134efa..c227e04 100644
--- a/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java
+++ b/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedTemporaryUrlBlobSigner.java
@@ -88,6 +88,7 @@ public class RegionScopedTemporaryUrlBlobSigner implements BlobRequestSigner {
return sign("PUT", container, blob.getMetadata().getName(), GetOptions.NONE, timestamp.get() + timeInSeconds);
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
return sign("DELETE", container, name, GetOptions.NONE, timestamp.get() + YEAR);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java b/apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java
index e110012..015b5e6 100644
--- a/apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java
+++ b/apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobRequestSigner.java
@@ -95,6 +95,7 @@ public class S3BlobRequestSigner<T extends S3Client> implements BlobRequestSigne
return cleanRequest(authSigner.signForTemporaryAccess(request, timeInSeconds));
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
checkNotNull(container, "container");
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/blobstore/src/main/java/org/jclouds/blobstore/BlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/blobstore/src/main/java/org/jclouds/blobstore/BlobRequestSigner.java b/blobstore/src/main/java/org/jclouds/blobstore/BlobRequestSigner.java
index 8464dad..a86a84a 100644
--- a/blobstore/src/main/java/org/jclouds/blobstore/BlobRequestSigner.java
+++ b/blobstore/src/main/java/org/jclouds/blobstore/BlobRequestSigner.java
@@ -71,6 +71,7 @@ public interface BlobRequestSigner {
* @throws UnsupportedOperationException
* if not supported by the provider
*/
+ @Deprecated
HttpRequest signRemoveBlob(String container, String name);
/**
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/blobstore/src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/blobstore/src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java b/blobstore/src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java
index 3c54f4b..13f8520 100644
--- a/blobstore/src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java
+++ b/blobstore/src/main/java/org/jclouds/blobstore/LocalBlobRequestSigner.java
@@ -75,6 +75,7 @@ public class LocalBlobRequestSigner implements BlobRequestSigner {
throw new UnsupportedOperationException();
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
HttpRequest request = HttpRequest.builder().method("DELETE").endpoint(String.format("%s/%s/%s", endpoint.get(), container,
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/blobstore/src/main/java/org/jclouds/blobstore/internal/RequestSigningUnsupported.java
----------------------------------------------------------------------
diff --git a/blobstore/src/main/java/org/jclouds/blobstore/internal/RequestSigningUnsupported.java b/blobstore/src/main/java/org/jclouds/blobstore/internal/RequestSigningUnsupported.java
index 7770525..b3de332 100644
--- a/blobstore/src/main/java/org/jclouds/blobstore/internal/RequestSigningUnsupported.java
+++ b/blobstore/src/main/java/org/jclouds/blobstore/internal/RequestSigningUnsupported.java
@@ -41,6 +41,7 @@ public class RequestSigningUnsupported implements BlobRequestSigner {
throw new UnsupportedOperationException();
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
throw new UnsupportedOperationException();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2e7de9f8/providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java b/providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java
index 7a365ed..38fe95b 100644
--- a/providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java
+++ b/providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java
@@ -83,6 +83,7 @@ public class AzureBlobRequestSigner implements BlobRequestSigner {
throw new UnsupportedOperationException();
}
+ @Deprecated
@Override
public HttpRequest signRemoveBlob(String container, String name) {
checkNotNull(container, "container");