[jira] [Comment Edited] (OAK-8054) RepMembersConflictHandler creates property with wrong type

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771763#comment-16771763 ] 

Alex Deparvu edited comment on OAK-8054 at 3/22/19 10:53 AM:
-------------------------------------------------------------

* trunk: fixed with http://svn.apache.org/viewvc?rev=1853868&view=rev
* 1.10: http://svn.apache.org/viewvc?rev=1854053&view=rev
* 1.8: http://svn.apache.org/viewvc?rev=1856039&view=rev


was (Author: alex.parvulescu):
* trunk: fixed with http://svn.apache.org/viewvc?rev=1853868&view=rev
* 1.10: http://svn.apache.org/viewvc?rev=1854053&view=rev

> RepMembersConflictHandler creates property with wrong type
> ----------------------------------------------------------
>
>                 Key: OAK-8054
>                 URL: https://issues.apache.org/jira/browse/OAK-8054
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, security
>    Affects Versions: 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.8.7, 1.8.8, 1.8.9, 1.8.10, 1.8.11, 1.8.12, 1.10
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Critical
>              Labels: candidate_oak_1_8
>             Fix For: 1.12, 1.11.0, 1.10.1
>
>         Attachments: OAK-8054-impact.patch, OAK-8054.patch
>
>
> The {{RepMembersConflictHandler}} handler uses type {{STRING}} instead of {{WEAKREFERENCE}} [0] as per the property's definition, which will trigger the type validation to fail the commit.
> Running external login tests I see that the type fails as soon as the handler comes into play:
> {noformat}
> WARN  o.a.j.o.s.s.a.e.i.ExternalLoginModule - User synchronization failed during commit: org.apache.jackrabbit.oak.api.CommitFailedException: OakConstraint0004: /rep:security/rep:authorizables/rep:groups/pathPrefix/g8/rep:membersList/9[[rep:MemberReferences]]: No matching property definition found for rep:members = [8e490910-17b6-30c1-8e11-6abdfa8a4ebc, 1a8e79f5-428e-39e9-88bb-2b86bd9b402e, ... ]. (attempt 10/50)
> {noformat}
> This seems to be a pretty big issue, and I'm not yet sure why it wasn't caught by the existing tests.
> // fyi [~anchela]
> [0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/RepMembersConflictHandler.java#L135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)