You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/08/15 09:41:17 UTC
[GitHub] [hbase] ndimiduk opened a new pull request, #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
ndimiduk opened a new pull request, #4706:
URL: https://github.com/apache/hbase/pull/4706
Signed-off-by: stack <st...@apache.org>
Signed-off-by: Viraj Jasani <vj...@apache.org>
Signed-off-by: Josh Elser <el...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Posted by GitBox <gi...@apache.org>.
Apache9 commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1214982621
This is for aligning the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1214860859
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 19s | branch-2 passed |
| +1 :green_heart: | compile | 2m 15s | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 33s | branch-2 passed |
| +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 1m 18s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 10s | the patch passed |
| +1 :green_heart: | compile | 2m 14s | the patch passed |
| -0 :warning: | javac | 2m 14s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) |
| +1 :green_heart: | checkstyle | 0m 31s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 48s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 1m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 32m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4706 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile |
| uname | Linux 8ce6af393516 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b83165cf60 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt |
| Max. process+thread count | 65 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
ndimiduk merged PR #4706:
URL: https://github.com/apache/hbase/pull/4706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
Apache9 commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1216104129
> I mean, maybe @BukrosSzabolcs or @busbey can confirm. I'd rather not backport changes that are not required.
The problem on master is we change to use slf4j style formatter but actually we do not use slf4j here, it is String.format...
On branch-2 we even do not use String.format, we just use '+' to concat the error message so no actually bug...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1214998617
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 54s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 47s | branch-2 passed |
| +1 :green_heart: | compile | 0m 42s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 25s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 42s | the patch passed |
| +1 :green_heart: | javac | 0m 42s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 184m 27s | hbase-server in the patch passed. |
| | | 203m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4706 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 34b71f7a2224 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b83165cf60 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/testReport/ |
| Max. process+thread count | 2759 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
busbey commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1218908610
One of the distributed mob compaction changes brought in this bug on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1215014943
> This is for aligning the code?
@Apache9 Yes it's one of the missing patches that @BukrosSzabolcs listed on HBASE-27154.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1214997373
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 54s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 22s | branch-2 passed |
| +1 :green_heart: | compile | 0m 34s | branch-2 passed |
| +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 4s | the patch passed |
| +1 :green_heart: | compile | 0m 34s | the patch passed |
| +1 :green_heart: | javac | 0m 34s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 185m 39s | hbase-server in the patch passed. |
| | | 202m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4706 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7463f699fa97 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b83165cf60 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/testReport/ |
| Max. process+thread count | 2364 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
Apache9 commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1215022186
> > This is for aligning the code?
>
> @Apache9 Yes it's one of the missing patches that @BukrosSzabolcs listed on [HBASE-27154](https://issues.apache.org/jira/browse/HBASE-27154).
I mean the problem describe on HBASE-24163 does not exist on branch-2. But anyway, no harm to align the code .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1217902425
Yep, I see that. I wonder what patch brought in the bug that this one fixed on master, it apparently hasn't been back ported to branch-2 yet.
Anyway, I'll continue this backport so that the active release lines remain fairly similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4706: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1214826518
FYI @BukrosSzabolcs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on PR #4706:
URL: https://github.com/apache/hbase/pull/4706#issuecomment-1215386869
I mean, maybe @BukrosSzabolcs or @busbey can confirm. I'd rather not backport changes that are not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org