[GitHub] sven-lange-last commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient

[GitBox <gi...@apache.org>]

sven-lange-last commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient
URL: https://github.com/apache/incubator-openwhisk/pull/4141#issuecomment-454063648
 
 
   @dubee when I run the original test code you are proposing to change, this test fails on my Mac: https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/org/apache/openwhisk/core/containerpool/docker/test/ApacheBlockingContainerClientTests.scala#L122
   
   ```
   org.scalatest.exceptions.TestFailedException: Left(ConnectionError(org.apache.http.conn.ConnectTimeoutException: Connect to 0.0.0.0:12345 [/0.0.0.0] failed: connect timed out)) was not a Timeout(RetryableConnectionError(HttpHostConnectException)))
   
   	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
   	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
   	at org.scalatest.FlatSpec.newAssertionFailedException(FlatSpec.scala:1685)
   	at org.scalatest.Assertions.fail(Assertions.scala:1089)
   	at org.scalatest.Assertions.fail$(Assertions.scala:1085)
   	at org.scalatest.FlatSpec.fail(FlatSpec.scala:1685)
   	at org.apache.openwhisk.core.containerpool.docker.test.ApacheBlockingContainerClientTests.$anonfun$new$4(ApacheBlockingContainerClientTests.scala:134)
   ...
   ```
   
   Which OS are you running this test on? Does it work in your dev environment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services