You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "devCod3r (via GitHub)" <gi...@apache.org> on 2023/04/20 12:34:10 UTC
[GitHub] [eventmesh] devCod3r opened a new pull request, #3782: [ISSUE #3012] Method modified to handle auto-closeable resource [TopicHandler]
devCod3r opened a new pull request, #3782:
URL: https://github.com/apache/eventmesh/pull/3782
Fixes #3012
### Motivation
*This method allocates and uses an auto closeable resource. However, it manually closes the resource in a finally block. While this is correct management, it doesn't rely on the idiomatic way available to JDK 7 and above, allows for possible subtle problems, and complicates the reading of code by developers expecting the use of try-with-resources.*
*Fixes the above mentioned issue.*
Issue #3012
### Modifications
*Changed conventional try-catch-finally block to try-with-resources.*
### Documentation
- Does this pull request introduce a new feature?
- Ans: no
- If a feature is not applicable for documentation, explain why?
- Ans: Replaced conventional try-catch-finally block to try-with-resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3782: [ISSUE #3012] Method modified to handle auto-closeable resource [TopicHandler]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3782:
URL: https://github.com/apache/eventmesh/pull/3782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3782: [ISSUE #3012] Method modified to handle auto-closeable resource [TopicHandler]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3782:
URL: https://github.com/apache/eventmesh/pull/3782#issuecomment-1521103084
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3782?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3782](https://codecov.io/gh/apache/eventmesh/pull/3782?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b773a8f) into [master](https://codecov.io/gh/apache/eventmesh/commit/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d3bbde) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head b773a8f differs from pull request most recent head b880a2f. Consider uploading reports for the commit b880a2f to get more accurate results
```diff
@@ Coverage Diff @@
## master #3782 +/- ##
============================================
- Coverage 13.80% 13.79% -0.01%
Complexity 1291 1291
============================================
Files 571 571
Lines 29154 29135 -19
Branches 2856 2841 -15
============================================
- Hits 4024 4020 -4
+ Misses 24756 24742 -14
+ Partials 374 373 -1
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3782?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/runtime/admin/handler/TopicHandler.java](https://codecov.io/gh/apache/eventmesh/pull/3782?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVG9waWNIYW5kbGVyLmphdmE=) | `7.14% <0.00%> (+0.89%)` | :arrow_up: |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3782/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org