[jira] [Work logged] (TS-4871) CID 1362796: Integer handling issues (NEGATIVE_RETURNS) in statistics plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4871?focusedWorklogId=29131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29131 ]

ASF GitHub Bot logged work on TS-4871:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/16 16:47
            Start Date: 15/Sep/16 16:47
    Worklog Time Spent: 10m 
      Work Description: GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/1023

    TS-4871: Check for TSStatCreate failure.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4871

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1023
    
----

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 29131)
            Time Spent: 10m
    Remaining Estimate: 0h

> CID 1362796:  Integer handling issues  (NEGATIVE_RETURNS) in statistics plugin
> ------------------------------------------------------------------------------
>
>                 Key: TS-4871
>                 URL: https://issues.apache.org/jira/browse/TS-4871
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Leif Hedstrom
>            Assignee: James Peach
>              Labels: coverity
>             Fix For: 7.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> *** CID 1362796:  Integer handling issues  (NEGATIVE_RETURNS)
> /example/statistic/statistic.cc: 50 in TSPluginInit()
> 44     
> 45       int id;
> 46       const char name[] = "example.statistic.now";
> 47     
> 48       if (TSStatFindName(name, &id) == TS_ERROR) {
> 49         id = TSStatCreate(name, TS_RECORDDATATYPE_INT, TS_STAT_NON_PERSISTENT, TS_STAT_SYNC_SUM);
>    CID 1362796:  Integer handling issues  (NEGATIVE_RETURNS)
>    Variable "id" tests negative.
> 50         if (id == TS_ERROR) {
> 51           TSError("%s: failed to register '%s'", PLUGIN_NAME, name);
> 52         }
> 53       }
> 54     
> 55       TSError("%s: %s registered with id %d", PLUGIN_NAME, name, id);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)