You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/05/24 16:58:14 UTC

[GitHub] [avro] slominskir opened a new pull request #1235: Conditional Java String type schema modification

slominskir opened a new pull request #1235:
URL: https://github.com/apache/avro/pull/1235


   Add option to skip the schema mangling step in the Java AVRO compiler that breaks compatibility between Java and Python (and other languages).  
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following issues:
     - https://issues.apache.org/jira/browse/AVRO-2838
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] slominskir commented on pull request #1235: AVRO-2838: Conditional Java String type schema modification

Posted by GitBox <gi...@apache.org>.
slominskir commented on pull request #1235:
URL: https://github.com/apache/avro/pull/1235#issuecomment-856107970


   Ran "mvn spotless:apply" to correct formatting then force pushed (squashed changes to keep single commit with required message prefix)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org