[GitHub] [pulsar] hangc0276 commented on a change in pull request #12217: Disable stats recorder for built-in PulsarClient

[GitBox <gi...@apache.org>]

hangc0276 commented on a change in pull request #12217:
URL: https://github.com/apache/pulsar/pull/12217#discussion_r717220264



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1327,6 +1327,8 @@ public synchronized PulsarClient getClient() throws PulsarServerException {
                             this.getConfiguration().getBrokerClientAuthenticationPlugin(),
                             this.getConfiguration().getBrokerClientAuthenticationParameters()));
                 }
+
+                conf.setStatsIntervalSeconds(0);

Review comment:
       For the pulsar replicator, it also call this `getClient` method to init pulsar client, which should retain the stats. So we'd better add a parameter to decide whether keep the client stats.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org