[jira] [Commented] (SAMZA-1412) remove mockito-all from the dependency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260164#comment-16260164 ] 

ASF GitHub Bot commented on SAMZA-1412:
---------------------------------------

GitHub user fredji97 opened a pull request:

    https://github.com/apache/samza/pull/365

    SAMZA-1412 replace mockito-all with mockito-core

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredji97/samza mockito-core

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #365
    
----
commit 6d7ec1e21419b3406aba7fd2d1e6391f90bcdcc5
Author: Fred Ji <ha...@gmail.com>
Date:   2017-11-21T01:59:12Z

    SAMZA-1412 replace mockito-all with mockito-core

----


> remove mockito-all from the dependency
> --------------------------------------
>
>                 Key: SAMZA-1412
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1412
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Fred Ji
>            Assignee: Fred Ji
>             Fix For: 0.14.0
>
>
> It is bad practice to use mockito-all because mockito-all include some of dependency's code in the package, which makes the dependency resolving not work expected and causes conflicting issues. For example, mockito-all include the code for hamcrest which may make the dependency point to the class in mockito-all instead of hamcrest-core, if there are any incompatible change in hamcrest, it will cause failure.  
> We should remove mockito-all and use mockito-core in the dependency for samza. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)