You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Brock Noland (Commented) (JIRA)" <ji...@apache.org> on 2012/02/28 17:11:46 UTC
[jira] [Commented] (MRUNIT-70) copy(orig, conf) in Serialization
shouldn't require objects to have a no-args constructor, and copy(orig,
copy, conf) seems to violate contract for deserializer.deserialize()
[ https://issues.apache.org/jira/browse/MRUNIT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218302#comment-13218302 ]
Brock Noland commented on MRUNIT-70:
------------------------------------
Writables must have a default constructor because they are created via reflection. WritableSerialization, the class, does the same thing we do via ReflectionUtils. Are you not using Writables?
https://svn.apache.org/repos/asf/hadoop/common/branches/branch-1/src/core/org/apache/hadoop/io/serializer/
> copy(orig, conf) in Serialization shouldn't require objects to have a no-args constructor, and copy(orig, copy, conf) seems to violate contract for deserializer.deserialize()
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-70
> URL: https://issues.apache.org/jira/browse/MRUNIT-70
> Project: MRUnit
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Meloss Xeloss
> Priority: Minor
>
> The copy(orig, conf) method requires objects to have a no-args constructor, which is non-ideal, since it passes on to Deserializer.deserialize, which can create a new object if passed in null. Additionally, the contract for deserialize only _can_ fill in the object passed in, so the copy method will not perform as expected if it does not.
> http://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/io/serializer/Deserializer.html#deserialize%28T%29
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira