You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by lw-lin <gi...@git.apache.org> on 2016/09/27 14:18:23 UTC
[GitHub] flink pull request #2557: [FLINK-3734] Close stream state handles after stat...
GitHub user lw-lin opened a pull request:
https://github.com/apache/flink/pull/2557
[FLINK-3734] Close stream state handles after state restorations
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/flink close-stream-state-handles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2557
----
commit eb2e2e45c7d76905b2b247954e4ef81f34ce471b
Author: Liwei Lin <lw...@gmail.com>
Date: 2016-09-27T14:12:23Z
[FLINK-3734] Close stream state handles after state restorations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2557: [FLINK-3734] Close stream state handles after stat...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin closed the pull request at:
https://github.com/apache/flink/pull/2557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2557: [FLINK-3734] Close stream state handles after stat...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2557#discussion_r80704455
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ---
@@ -568,8 +568,8 @@ public void setInitialState(ChainedStateHandle<StreamStateHandle> chainedState,
private void restoreState() throws Exception {
final StreamOperator<?>[] allOperators = operatorChain.getAllOperators();
- try {
- if (lazyRestoreChainedOperatorState != null) {
+ if (lazyRestoreChainedOperatorState != null) {
--- End diff --
this `if (lazyRestoreChainedOperatorState != null)` check was moved out of the `try` block because the same check is required in the `finally` block
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2557: [FLINK-3734] Close stream state handles after state resto...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on the issue:
https://github.com/apache/flink/pull/2557
Glad to see this issue got fixed along with https://github.com/apache/flink/pull/2512 -- the fix is [this line in StreamTask](https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java#L577).
So @tedyu would you mind closing FLINK-3734? :-D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2557: [FLINK-3734] Close stream state handles after state resto...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2557
There is a big change to the internal state life cycle coming up: #2512
Could you have a look whether the problem you found still exists in that code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---