[jira] [Commented] (ARTEMIS-2190) Core JMS client leaks temporary destination names

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733926#comment-16733926 ] 

ASF GitHub Bot commented on ARTEMIS-2190:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2477
  
    LGTM - would merge for you but currently abroad and don;t have access to my computer with my apache git ssh key, feel free to merge.


> Core JMS client leaks temporary destination names
> -------------------------------------------------
>
>                 Key: ARTEMIS-2190
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2190
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.5, 2.6.0
>            Reporter: Tom Ross
>            Assignee: Justin Bertram
>            Priority: Major
>
> The core JMS client leaks the {{SimpleString}} identifiers for temporary destinations. When a temporary JMS destination is created it is added to two lists on {{ActiveMQConnection}}, but when it is deleted it is only removed from one list.
> {code:java}
> public void addTemporaryQueue(final SimpleString queueAddress) {
>  tempQueues.add(queueAddress);
>  knownDestinations.add(queueAddress);
> }
> public void removeTemporaryQueue(final SimpleString queueAddress) {
>  tempQueues.remove(queueAddress);
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)