You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2024/03/06 15:13:32 UTC
Error while starting the release procedure
Hello,
it seems that I cannot perform the usual release procedure, we change
the rules on the GH repo
How did we do in the previous releases ?
Below you can find the error
Enrico
ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0-M5:branch
(default-cli) on project bookkeeper: Unable to commit files
[ERROR] Provider message:
[ERROR] The git-push command failed.
[ERROR] Command output:
[ERROR] remote: error: GH006: Protected branch update failed for
refs/heads/master.
[ERROR] remote: error: Changes must be made through a pull request. 14
of 14 required status checks are expected.
[ERROR] To https://github.com/apache/bookkeeper.git
[ERROR] ! [remote rejected] master -> master (protected branch
hook declined)
[ERROR] error: failed to push some refs to
'https://github.com/apache/bookkeeper.git'
Re: Error while starting the release procedure
Posted by Lari Hotari <lh...@apache.org>.
Here's the fix to this issue:
https://github.com/apache/bookkeeper/pull/4237
-Lari
On 2024/03/20 23:52:35 Lari Hotari wrote:
> I was able to reproduce the problem now.
> With PR 4235 and PR 4236 changes under 000-run-docker.sh environment,
> I simulated the deployment to a local directory with this configuration:
> mkdir .mvn
> echo '-DaltDeploymentRepository=local::default::file:./target/staging-deploy' > .mvn/jvm.config
> dev/release/003-release-perform.sh
>
> After asking gpg password, it will soon fail with
> [INFO] [INFO] --- source:3.3.0:jar (attach-sources) @ buildtools ---
> [INFO] [INFO] Building jar: /Users/lari/workspace-pulsar/bookkeeper/target/checkout/buildtools/target/buildtools-4.17.0-sources.jar
> [INFO] [INFO]
> [INFO] [INFO] --- source:3.3.0:jar-no-fork (attach-sources) @ buildtools ---
> [INFO] [ERROR] We have duplicated artifacts attached.
> ...
> [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project buildtools: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them. -> [Help 1]
> [INFO] [ERROR]
>
> While testing, I have modified the pom.xml scm/connection and scm/developerConnection values to point to my fork.
>
> I guess it's easier to fix, now that there's a way to reproduce and test the fix.
>
> -Lari
>
> On 2024/03/20 23:38:58 Lari Hotari wrote:
> > On 2024/03/16 07:13:08 Enrico Olivelli wrote:
> > > There is a problem in the release process due to some update to the pom
> > > file, we are executing the source plugin twice.
> > > I haven't dug yet
> > >
> > > I will keep you updated
> >
> > Hi Enrico,
> >
> > Did you already solve the problem? The build was updated when I fixed the integration tests in https://github.com/apache/bookkeeper/pull/4197. I also updated most maven plugins since there were some challenges with outdated plugin versions. I hope this didn't break things.
> >
> > I tried to debug the issue and made 2 PRs to fix issues when using the 000-run-docker.sh solution on MacOS. There are the PRs:
> > - https://github.com/apache/bookkeeper/pull/4235
> > - https://github.com/apache/bookkeeper/pull/4236
> >
> > With these changes dev/release/002-release-prepare.sh passed without errors and I got 003-release-perform.sh to run all the way until it starts uploading artifacts (this fails since I didn't reconfigure a test destination).
> >
> > > file, we are executing the source plugin twice.
> >
> > What is the error message and the impact of executing this twice?
> >
> > Hopefully we get the release process fixed and can proceed asap. Thanks for everyone who has contributed to the release and is performing release activities!
> >
> > -Lari
> >
> >
> > >
> > > Enrico
> > >
> > > Il Mer 6 Mar 2024, 16:13 Enrico Olivelli <eo...@gmail.com> ha scritto:
> > >
> > > > Hello,
> > > > it seems that I cannot perform the usual release procedure, we change
> > > > the rules on the GH repo
> > > >
> > > > How did we do in the previous releases ?
> > > > Below you can find the error
> > > >
> > > > Enrico
> > > >
> > > > ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-release-plugin:3.0.0-M5:branch
> > > > (default-cli) on project bookkeeper: Unable to commit files
> > > > [ERROR] Provider message:
> > > > [ERROR] The git-push command failed.
> > > > [ERROR] Command output:
> > > > [ERROR] remote: error: GH006: Protected branch update failed for
> > > > refs/heads/master.
> > > > [ERROR] remote: error: Changes must be made through a pull request. 14
> > > > of 14 required status checks are expected.
> > > > [ERROR] To https://github.com/apache/bookkeeper.git
> > > > [ERROR] ! [remote rejected] master -> master (protected branch
> > > > hook declined)
> > > > [ERROR] error: failed to push some refs to
> > > > 'https://github.com/apache/bookkeeper.git'
> > > >
> > >
> >
>
Re: Error while starting the release procedure
Posted by Lari Hotari <lh...@apache.org>.
I was able to reproduce the problem now.
With PR 4235 and PR 4236 changes under 000-run-docker.sh environment,
I simulated the deployment to a local directory with this configuration:
mkdir .mvn
echo '-DaltDeploymentRepository=local::default::file:./target/staging-deploy' > .mvn/jvm.config
dev/release/003-release-perform.sh
After asking gpg password, it will soon fail with
[INFO] [INFO] --- source:3.3.0:jar (attach-sources) @ buildtools ---
[INFO] [INFO] Building jar: /Users/lari/workspace-pulsar/bookkeeper/target/checkout/buildtools/target/buildtools-4.17.0-sources.jar
[INFO] [INFO]
[INFO] [INFO] --- source:3.3.0:jar-no-fork (attach-sources) @ buildtools ---
[INFO] [ERROR] We have duplicated artifacts attached.
...
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project buildtools: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them. -> [Help 1]
[INFO] [ERROR]
While testing, I have modified the pom.xml scm/connection and scm/developerConnection values to point to my fork.
I guess it's easier to fix, now that there's a way to reproduce and test the fix.
-Lari
On 2024/03/20 23:38:58 Lari Hotari wrote:
> On 2024/03/16 07:13:08 Enrico Olivelli wrote:
> > There is a problem in the release process due to some update to the pom
> > file, we are executing the source plugin twice.
> > I haven't dug yet
> >
> > I will keep you updated
>
> Hi Enrico,
>
> Did you already solve the problem? The build was updated when I fixed the integration tests in https://github.com/apache/bookkeeper/pull/4197. I also updated most maven plugins since there were some challenges with outdated plugin versions. I hope this didn't break things.
>
> I tried to debug the issue and made 2 PRs to fix issues when using the 000-run-docker.sh solution on MacOS. There are the PRs:
> - https://github.com/apache/bookkeeper/pull/4235
> - https://github.com/apache/bookkeeper/pull/4236
>
> With these changes dev/release/002-release-prepare.sh passed without errors and I got 003-release-perform.sh to run all the way until it starts uploading artifacts (this fails since I didn't reconfigure a test destination).
>
> > file, we are executing the source plugin twice.
>
> What is the error message and the impact of executing this twice?
>
> Hopefully we get the release process fixed and can proceed asap. Thanks for everyone who has contributed to the release and is performing release activities!
>
> -Lari
>
>
> >
> > Enrico
> >
> > Il Mer 6 Mar 2024, 16:13 Enrico Olivelli <eo...@gmail.com> ha scritto:
> >
> > > Hello,
> > > it seems that I cannot perform the usual release procedure, we change
> > > the rules on the GH repo
> > >
> > > How did we do in the previous releases ?
> > > Below you can find the error
> > >
> > > Enrico
> > >
> > > ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-release-plugin:3.0.0-M5:branch
> > > (default-cli) on project bookkeeper: Unable to commit files
> > > [ERROR] Provider message:
> > > [ERROR] The git-push command failed.
> > > [ERROR] Command output:
> > > [ERROR] remote: error: GH006: Protected branch update failed for
> > > refs/heads/master.
> > > [ERROR] remote: error: Changes must be made through a pull request. 14
> > > of 14 required status checks are expected.
> > > [ERROR] To https://github.com/apache/bookkeeper.git
> > > [ERROR] ! [remote rejected] master -> master (protected branch
> > > hook declined)
> > > [ERROR] error: failed to push some refs to
> > > 'https://github.com/apache/bookkeeper.git'
> > >
> >
>
Re: Error while starting the release procedure
Posted by Lari Hotari <lh...@apache.org>.
On 2024/03/16 07:13:08 Enrico Olivelli wrote:
> There is a problem in the release process due to some update to the pom
> file, we are executing the source plugin twice.
> I haven't dug yet
>
> I will keep you updated
Hi Enrico,
Did you already solve the problem? The build was updated when I fixed the integration tests in https://github.com/apache/bookkeeper/pull/4197. I also updated most maven plugins since there were some challenges with outdated plugin versions. I hope this didn't break things.
I tried to debug the issue and made 2 PRs to fix issues when using the 000-run-docker.sh solution on MacOS. There are the PRs:
- https://github.com/apache/bookkeeper/pull/4235
- https://github.com/apache/bookkeeper/pull/4236
With these changes dev/release/002-release-prepare.sh passed without errors and I got 003-release-perform.sh to run all the way until it starts uploading artifacts (this fails since I didn't reconfigure a test destination).
> file, we are executing the source plugin twice.
What is the error message and the impact of executing this twice?
Hopefully we get the release process fixed and can proceed asap. Thanks for everyone who has contributed to the release and is performing release activities!
-Lari
>
> Enrico
>
> Il Mer 6 Mar 2024, 16:13 Enrico Olivelli <eo...@gmail.com> ha scritto:
>
> > Hello,
> > it seems that I cannot perform the usual release procedure, we change
> > the rules on the GH repo
> >
> > How did we do in the previous releases ?
> > Below you can find the error
> >
> > Enrico
> >
> > ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-release-plugin:3.0.0-M5:branch
> > (default-cli) on project bookkeeper: Unable to commit files
> > [ERROR] Provider message:
> > [ERROR] The git-push command failed.
> > [ERROR] Command output:
> > [ERROR] remote: error: GH006: Protected branch update failed for
> > refs/heads/master.
> > [ERROR] remote: error: Changes must be made through a pull request. 14
> > of 14 required status checks are expected.
> > [ERROR] To https://github.com/apache/bookkeeper.git
> > [ERROR] ! [remote rejected] master -> master (protected branch
> > hook declined)
> > [ERROR] error: failed to push some refs to
> > 'https://github.com/apache/bookkeeper.git'
> >
>
Re: Error while starting the release procedure
Posted by Enrico Olivelli <eo...@gmail.com>.
Hello
A quick update.
I have created branch-4.17 and now master is 4.18
There is a problem in the release process due to some update to the pom
file, we are executing the source plugin twice.
I haven't dug yet
I will keep you updated
Enrico
Il Mer 6 Mar 2024, 16:13 Enrico Olivelli <eo...@gmail.com> ha scritto:
> Hello,
> it seems that I cannot perform the usual release procedure, we change
> the rules on the GH repo
>
> How did we do in the previous releases ?
> Below you can find the error
>
> Enrico
>
> ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M5:branch
> (default-cli) on project bookkeeper: Unable to commit files
> [ERROR] Provider message:
> [ERROR] The git-push command failed.
> [ERROR] Command output:
> [ERROR] remote: error: GH006: Protected branch update failed for
> refs/heads/master.
> [ERROR] remote: error: Changes must be made through a pull request. 14
> of 14 required status checks are expected.
> [ERROR] To https://github.com/apache/bookkeeper.git
> [ERROR] ! [remote rejected] master -> master (protected branch
> hook declined)
> [ERROR] error: failed to push some refs to
> 'https://github.com/apache/bookkeeper.git'
>