You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (Created) (JIRA)" <ji...@apache.org> on 2011/11/10 00:55:51 UTC
[jira] [Created] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
naming errors for TestHLogUtils and SoftValueSortedMapTest
----------------------------------------------------------
Key: HBASE-4764
URL: https://issues.apache.org/jira/browse/HBASE-4764
Project: HBase
Issue Type: Improvement
Components: test
Affects Versions: 0.94.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149913#comment-13149913 ]
Ted Yu commented on HBASE-4764:
-------------------------------
TestMasterFailover hung.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149110#comment-13149110 ]
stack commented on HBASE-4764:
------------------------------
+1 on proposed changes
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150364#comment-13150364 ]
Ted Yu commented on HBASE-4764:
-------------------------------
I think HLogUtilsForTests.java wasn't added to source repository, causing compilation error.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150001#comment-13150001 ]
nkeywal commented on HBASE-4764:
--------------------------------
For example, after a look at the code where the above sample blocks; the current implementation is:
{noformat}
while (!this.stopped && (notimeout || remaining > 0) && this.data == null) {
if (notimeout) {
wait();
continue;
}
wait(remaining);
remaining = timeout - (System.currentTimeMillis() - startTime);
}
{noformat}
This means that if the notification is sent before we actually started waiting, we will wait forever. Probability is quite low and I don't think that's the root cause here, but who knows?. An implementation like this one would be more secure:
{noformat}
long previousLogTime = 0;
while (!this.stopped && (notimeout || remaining > 0) && this.data == null) {
if (System.currentTimeMillis() > previousLogTime + 1000) {
LOG.info("Waiting for node to be available ");
previousLogTime = System.currentTimeMillis();
}
wait(200);
remaining = timeout - (System.currentTimeMillis() - startTime);
}
{noformat}
The is no notifications in getData(), don't know if it's voluntary.
The recursive call to start in ZooKeeperNodeTracker#start() is not really necessary.
But to conclude, we don't even know if it's a stack like this one on the build machine.
Can we put a script in the cron tab? Something that would run every 10 minutes and look for dead processes? We could also hijack a maven task to run a script when it's launched and make it send a mail.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149929#comment-13149929 ]
Ted Yu commented on HBASE-4764:
-------------------------------
I don't have access to the build machine.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-4764:
---------------------------
Status: Patch Available (was: Open)
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149099#comment-13149099 ]
nkeywal commented on HBASE-4764:
--------------------------------
@committers: please tell if you're ok with:
- TestHLogUtils: renaming
- SoftValueSortedMapTest: renaming + JUnitization if included tests works, deletion otherwise.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-4764:
---------------------------
Attachment: 4764_trunk.patch
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149937#comment-13149937 ]
nkeywal commented on HBASE-4764:
--------------------------------
It's gonna be difficult :-). I will have a look at my own stack, but I don't know if they have a lot of value. Here is an extract from yesterday:
{noformat}
Thread 2916: (state = BLOCKED)
- java.lang.Object.wait(long) @bci=0 (Interpreted frame)
- org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(long, boolean) @bci=113, line=134 (Interpreted frame)
- org.apache.hadoop.hbase.zookeeper.RootRegionTracker.waitRootRegionLocation(long) @bci=32, line=83 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(byte[], byte[], boolean) @bci=75, line=753 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.relocateRegion(byte[], byte[]) @bci=4, line=739 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getRegionLocation(byte[], byte[], boolean) @bci=7, line=658 (Interpreted frame)
- org.apache.hadoop.hbase.client.ServerCallable.connect(boolean) @bci=14, line=75 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getRegionServerWithRetries(org.apache.hadoop.hbase.client.ServerCallable) @bci=32, line=1241 (Interpreted frame)
- org.apache.hadoop.hbase.client.HTable.get(org.apache.hadoop.hbase.client.Get) @bci=29, line=589 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.MetaReader.get(org.apache.hadoop.hbase.client.HTable, org.apache.hadoop.hbase.client.Get) @bci=2, line=245 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.MetaReader.getRegion(org.apache.hadoop.hbase.catalog.CatalogTracker, byte[]) @bci=23, line=347 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.MetaReader.readRegionLocation(org.apache.hadoop.hbase.catalog.CatalogTracker, byte[]) @bci=2, line=287 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.MetaReader.getMetaRegionLocation(org.apache.hadoop.hbase.catalog.CatalogTracker) @bci=4, line=274 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.CatalogTracker.getMetaServerConnection() @bci=50, line=399 (Interpreted frame)
- org.apache.hadoop.hbase.catalog.CatalogTracker.waitForMeta(long) @bci=45, line=458 (Interpreted frame)
- org.apache.hadoop.hbase.master.handler.CreateTableHandler.<init>(org.apache.hadoop.hbase.Server, org.apache.hadoop.hbase.master.MasterFileSystem, org.apache.hadoop.hbase.master.ServerManager, org.apache.hadoop.hbase.HTableDescriptor, org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.HRegionInfo[], org.apache.hadoop.hbase.catalog.CatalogTracker, org.apache.hadoop.hbase.master.AssignmentManager) @bci=65, line=80 (Interpreted frame)
- org.apache.hadoop.hbase.master.HMaster.createTable(org.apache.hadoop.hbase.HTableDescriptor, byte[][]) @bci=69, line=998 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) @bci=0 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=87, line=39 (Interpreted frame)
- sun.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=6, line=25 (Compiled frame)
- java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object[]) @bci=161, line=597 (Compiled frame)
- org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(java.lang.Class, org.apache.hadoop.io.Writable, long, org.apache.hadoop.hbase.monitoring.MonitoredRPCHandler) @bci=279, line=364 (Interpreted frame)
- org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run() @bci=236, line=1306 (Interpreted frame)
Thread 2378: (state = BLOCKED)
- java.lang.Object.wait(long) @bci=0 (Interpreted frame)
- org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(long, boolean) @bci=113, line=134 (Interpreted frame)
- org.apache.hadoop.hbase.zookeeper.RootRegionTracker.waitRootRegionLocation(long) @bci=32, line=83 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(byte[], byte[], boolean) @bci=75, line=753 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(byte[], byte[]) @bci=4, line=733 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(byte[], byte[], byte[], boolean, java.lang.Object) @bci=97, line=866 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(byte[], byte[], boolean) @bci=189, line=765 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(byte[], byte[]) @bci=4, line=733 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getRegionLocation(byte[], byte[], boolean) @bci=16, line=658 (Interpreted frame)
- org.apache.hadoop.hbase.client.ServerCallable.connect(boolean) @bci=14, line=75 (Interpreted frame)
- org.apache.hadoop.hbase.client.ScannerCallable.connect(boolean) @bci=13, line=72 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getRegionServerWithRetries(org.apache.hadoop.hbase.client.ServerCallable) @bci=32, line=1241 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner.metaScan(org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.client.HConnection, org.apache.hadoop.hbase.client.MetaScanner$MetaScannerVisitor, byte[], byte[], int, byte[]) @bci=374, line=194 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner.access$000(org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.client.HConnection, org.apache.hadoop.hbase.client.MetaScanner$MetaScannerVisitor, byte[], byte[], int, byte[]) @bci=10, line=52 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner$1.connect(org.apache.hadoop.hbase.client.HConnection) @bci=25, line=130 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner$1.connect(org.apache.hadoop.hbase.client.HConnection) @bci=2, line=127 (Interpreted frame)
- org.apache.hadoop.hbase.client.HConnectionManager.execute(org.apache.hadoop.hbase.client.HConnectionManager$HConnectable) @bci=27, line=339 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner.metaScan(org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.client.MetaScanner$MetaScannerVisitor, byte[], byte[], int, byte[]) @bci=15, line=127 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner.metaScan(org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.client.MetaScanner$MetaScannerVisitor, byte[], byte[], int) @bci=9, line=103 (Interpreted frame)
- org.apache.hadoop.hbase.client.MetaScanner.metaScan(org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.client.MetaScanner$MetaScannerVisitor, byte[]) @bci=6, line=81 (Interpreted frame)
- org.apache.hadoop.hbase.client.HBaseAdmin.createTable(org.apache.hadoop.hbase.HTableDescriptor, byte[][]) @bci=121, line=394 (Interpreted frame)
- org.apache.hadoop.hbase.TestMultiVersions.testScanMultipleVersions() @bci=88, line=195 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) @bci=0 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=87, line=39 (Interpreted frame)
- sun.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=6, line=25 (Compiled frame)
- java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object[]) @bci=161, line=597 (Compiled frame)
- org.junit.runners.model.FrameworkMethod$1.runReflectiveCall() @bci=15, line=45 (Interpreted frame)
- org.junit.internal.runners.model.ReflectiveCallable.run() @bci=1, line=15 (Interpreted frame)
- org.junit.runners.model.FrameworkMethod.invokeExplosively(java.lang.Object, java.lang.Object[]) @bci=10, line=42 (Interpreted frame)
- org.junit.internal.runners.statements.InvokeMethod.evaluate() @bci=12, line=20 (Interpreted frame)
- org.junit.internal.runners.statements.RunBefores.evaluate() @bci=49, line=28 (Interpreted frame)
- org.junit.internal.runners.statements.RunAfters.evaluate() @bci=12, line=30 (Interpreted frame)
- org.junit.runners.ParentRunner.runLeaf(org.junit.runners.model.Statement, org.junit.runner.Description, org.junit.runner.notification.RunNotifier) @bci=17, line=263 (Interpreted frame)
- org.junit.runners.BlockJUnit4ClassRunner.runChild(org.junit.runners.model.FrameworkMethod, org.junit.runner.notification.RunNotifier) @bci=32, line=68 (Interpreted frame)
- org.junit.runners.BlockJUnit4ClassRunner.runChild(java.lang.Object, org.junit.runner.notification.RunNotifier) @bci=6, line=47 (Interpreted frame)
- org.junit.runners.ParentRunner$3.run() @bci=12, line=231 (Interpreted frame)
- org.junit.runners.ParentRunner$1.schedule(java.lang.Runnable) @bci=1, line=60 (Interpreted frame)
- org.junit.runners.ParentRunner.runChildren(org.junit.runner.notification.RunNotifier) @bci=40, line=229 (Interpreted frame)
- org.junit.runners.ParentRunner.access$000(org.junit.runners.ParentRunner, org.junit.runner.notification.RunNotifier) @bci=2, line=50 (Interpreted frame)
- org.junit.runners.ParentRunner$2.evaluate() @bci=8, line=222 (Interpreted frame)
- org.junit.internal.runners.statements.RunBefores.evaluate() @bci=49, line=28 (Interpreted frame)
- org.junit.internal.runners.statements.RunAfters.evaluate() @bci=12, line=30 (Interpreted frame)
- org.junit.runners.ParentRunner.run(org.junit.runner.notification.RunNotifier) @bci=20, line=300 (Interpreted frame)
- org.junit.runners.Suite.runChild(org.junit.runner.Runner, org.junit.runner.notification.RunNotifier) @bci=2, line=128 (Interpreted frame)
- org.junit.runners.Suite.runChild(java.lang.Object, org.junit.runner.notification.RunNotifier) @bci=6, line=24 (Interpreted frame)
- org.junit.runners.ParentRunner$3.run() @bci=12, line=231 (Interpreted frame)
- org.junit.runners.ParentRunner$1.schedule(java.lang.Runnable) @bci=1, line=60 (Interpreted frame)
- org.junit.runners.ParentRunner.runChildren(org.junit.runner.notification.RunNotifier) @bci=40, line=229 (Interpreted frame)
- org.junit.runners.ParentRunner.access$000(org.junit.runners.ParentRunner, org.junit.runner.notification.RunNotifier) @bci=2, line=50 (Interpreted frame)
- org.junit.runners.ParentRunner$2.evaluate() @bci=8, line=222 (Interpreted frame)
- org.junit.runners.ParentRunner.run(org.junit.runner.notification.RunNotifier) @bci=20, line=300 (Interpreted frame)
- org.junit.runner.JUnitCore.run(org.junit.runner.Runner) @bci=37, line=157 (Interpreted frame)
- org.junit.runner.JUnitCore.run(org.junit.runner.Request) @bci=5, line=136 (Interpreted frame)
- org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(org.apache.maven.surefire.util.TestsToRun, org.apache.maven.surefire.junitcore.JUnitCoreParameters, java.util.List, org.junit.runner.manipulation.Filter) @bci=82, line=61 (Interpreted frame)
- org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(java.lang.Object) @bci=150, line=119 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) @bci=0 (Interpreted frame)
- sun.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=87, line=39 (Interpreted frame)
- sun.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) @bci=6, line=25 (Interpreted frame)
- java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object[]) @bci=161, line=597 (Interpreted frame)
- org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(java.lang.Object, java.lang.reflect.Method, java.lang.Object[]) @bci=3, line=164 (Interpreted frame)
- org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(java.lang.Object) @bci=29, line=110 (Interpreted frame)
- org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(java.lang.Object, java.lang.ClassLoader, java.lang.ClassLoader, java.lang.Object) @bci=41, line=175 (Interpreted frame)
- org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(org.apache.maven.surefire.booter.TypeEncodedValue) @bci=64, line=81 (Interpreted frame)
- org.apache.maven.surefire.booter.ForkedBooter.main(java.lang.String[]) @bci=101, line=68 (Interpreted frame)
{noformat}
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-4764:
---------------------------
Status: Open (was: Patch Available)
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-4764:
---------------------------
Status: Patch Available (was: Open)
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150170#comment-13150170 ]
Hadoop QA commented on HBASE-4764:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503694/4764_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -163 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/248//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/248//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/248//console
This message is automatically generated.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150432#comment-13150432 ]
Hudson commented on HBASE-4764:
-------------------------------
Integrated in HBase-TRUNK #2442 (See [https://builds.apache.org/job/HBase-TRUNK/2442/])
HBASE-4764 Addendum add HLogUtilsForTests.java
tedyu :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogUtils.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/SoftValueSortedMapTest.java
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149903#comment-13149903 ]
Hadoop QA commented on HBASE-4764:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503651/4764_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -163 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 50 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/244//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/244//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/244//console
This message is automatically generated.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149928#comment-13149928 ]
nkeywal commented on HBASE-4764:
--------------------------------
@ted: If the process is still alive, can you jstack it? Dead processes can be identified by their ppid equals to 1, but it's still possible to jstack them with their pid.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150369#comment-13150369 ]
nkeywal commented on HBASE-4764:
--------------------------------
It worked on integration? Should I do something?
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149102#comment-13149102 ]
Ted Yu commented on HBASE-4764:
-------------------------------
I think the proposal makes sense.
See also http://markphip.blogspot.com/2006/12/subversion-moverename-feature.html
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4764:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied to trunk. Thanks for patch N.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-4764:
---------------------------
Attachment: 4764_trunk.patch
same patch try again
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150269#comment-13150269 ]
Hudson commented on HBASE-4764:
-------------------------------
Integrated in HBase-TRUNK #2441 (See [https://builds.apache.org/job/HBase-TRUNK/2441/])
HBASE-4764 naming errors for TestHLogUtils and SoftValueSortedMapTest
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150376#comment-13150376 ]
Ted Yu commented on HBASE-4764:
-------------------------------
HLogUtilsForTests.java has been added to source repository.
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4764_trunk.patch, 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149924#comment-13149924 ]
nkeywal commented on HBASE-4764:
--------------------------------
It's just a renaming of a class that impacted only client.TestAdmin? I checked again the patch, it seems ok
This said; I saw the tests randomly blocked in my env as well but not when I tested this patch. May be there is something else (I hope there is something else!).
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150041#comment-13150041 ]
nkeywal commented on HBASE-4764:
--------------------------------
Ok, may be we can handle this with a post build task that would execute a
script?
However, we need to be careful not to break anything, but it should work I
think.
On Mon, Nov 14, 2011 at 11:47 PM, stack (Commented) (JIRA)
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and
SoftValueSortedMapTest
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150031#comment-13150031 ]
stack commented on HBASE-4764:
------------------------------
@nkeywal We don't have access to the apache build boxes. My blanket "i want access" was rebuked with a "we have lots of build machines and giving you access to them all is untenable" (Fair enough I suppose)
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
> Key: HBASE-4764
> URL: https://issues.apache.org/jira/browse/HBASE-4764
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4764_trunk.patch
>
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira