You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/03 14:16:38 UTC
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6135: sched: cpuload: add pm callbacks for cpuidle and time compensate for idle task
gustavonihei commented on code in PR #6135:
URL: https://github.com/apache/incubator-nuttx/pull/6135#discussion_r863827953
##########
sched/sched/sched_cpuload_oneshot.c:
##########
@@ -225,6 +231,37 @@ static void nxsched_oneshot_callback(FAR struct oneshot_lowerhalf_s *lower,
nxsched_oneshot_start();
}
+#ifdef CONFIG_PM
+static void nxsched_oneshot_pmnotify(struct pm_callback_s *cb, int domain,
Review Comment:
```suggestion
static void nxsched_oneshot_pmnotify(FAR struct pm_callback_s *cb, int domain,
```
FAR is required here, since this file is common to all targets.
##########
sched/sched/sched_cpuload_oneshot.c:
##########
@@ -225,6 +231,37 @@ static void nxsched_oneshot_callback(FAR struct oneshot_lowerhalf_s *lower,
nxsched_oneshot_start();
}
+#ifdef CONFIG_PM
+static void nxsched_oneshot_pmnotify(struct pm_callback_s *cb, int domain,
Review Comment:
```suggestion
static void nxsched_oneshot_pmnotify(FAR struct pm_callback_s *cb, int domain,
```
`FAR` is required here, since this file is common to all targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org