You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by gi...@apache.org on 2020/12/29 13:24:16 UTC

[buildstream] 01/14: elements/stack.py: Forbid sources and build dependencies

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch chandan/stack-stricter-warnings
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit a2c9a6be0344426abe6ec7327949bcb1f11acd43
Author: Chandan Singh <cs...@bloomberg.net>
AuthorDate: Tue Jul 16 12:17:40 2019 +0100

    elements/stack.py: Forbid sources and build dependencies
    
    Since the `stack` plugin only cares about its runtime dependencies,
    explicitly forbid build dependencies and sources from being specified to
    avoid confusion.
    
    Fixes #1075.
---
 src/buildstream/plugins/elements/stack.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/buildstream/plugins/elements/stack.py b/src/buildstream/plugins/elements/stack.py
index 97517ca..4cacd3f 100644
--- a/src/buildstream/plugins/elements/stack.py
+++ b/src/buildstream/plugins/elements/stack.py
@@ -30,6 +30,12 @@ from buildstream import Element
 # Element implementation for the 'stack' kind.
 class StackElement(Element):
 
+    # This plugin ingores build dependencies, so disallow them
+    BST_FORBID_BDEPENDS = True
+
+    # This plugin ignores sources, so disallow them
+    BST_FORBID_SOURCES = True
+
     # This plugin has been modified to avoid the use of Sandbox.get_directory
     BST_VIRTUAL_DIRECTORY = True