[jira] [Commented] (IMPALA-7829) Send the final profile only after all fragment instances have been closed

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679476#comment-16679476 ] 

ASF subversion and git services commented on IMPALA-7829:
---------------------------------------------------------

Commit d1aa1c009f62500ae2ee8cd915751b0d42bee911 in impala's branch refs/heads/master from Michael Ho
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=d1aa1c0 ]

IMPALA-7828: A temporary workaround for flaky UDF test (test_mem_leak())

Before IMPALA-4063, the error message detected during
FragmentInstanceState::Close() was always lost. After
IMPALA-4063, we may sometimes get the error message in
FragmentInstanceState::Close(). It's non-deterministic
as the fragment instance thread may race with the query
state thread which reports the final status. The UDF test
currently tries to handle this non-determinism by using
"row_regex:.*" in the ERRORS section but it doesn't
always seem to work.

This change workarounds the issue by commenting out the
ERRORS section in udf-no-expr-rewrite.text for now.
The actual fix will be done in IMPALA-7829.

Change-Id: I6a55d5ad1a5a7278e7390f60854a8df28c1b9f28
Reviewed-on: http://gerrit.cloudera.org:8080/11900
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Send the final profile only after all fragment instances have been closed
> -------------------------------------------------------------------------
>
>                 Key: IMPALA-7829
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7829
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Distributed Exec
>    Affects Versions: Impala 3.2.0
>            Reporter: Michael Ho
>            Assignee: Michael Ho
>            Priority: Critical
>
> As shown in IMPALA-7828. there is some non-determinism on whether the errors detected in {{FragmentInstanceState::Close()}} will show up in the final profile sent to the coordinator. The reason is that the current code marks a fragment instance "done" after {{ExecInternal()}} completes but before {{Close()}} is called. There is a window in between when the final status report may be sent before {{Close()}} finishes. We should consider not sending the final report until {{Close()}} is done but we probably need to understand whether it has any implication to the overall reported query execution time. It should have no effect to the "First Rows Available" time for a query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org