You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/24 04:01:42 UTC
[GitHub] [druid] kfaraz commented on a change in pull request #11732: Add Broker config `druid.broker.segment.watchRealtimeNodes`
kfaraz commented on a change in pull request #11732:
URL: https://github.com/apache/druid/pull/11732#discussion_r715301094
##########
File path: server/src/main/java/org/apache/druid/client/BrokerSegmentWatcherConfig.java
##########
@@ -46,6 +49,11 @@
return watchedDataSources;
}
+ public boolean isWatchRealtimeNodes()
+ {
+ return watchRealtimeNodes;
+ }
Review comment:
I was thinking the same thing but then I realized that only a few combinations are possible here:
(a) REALTIME and HISTORICAL, (b) only HISTORICAL (and maybe (c) only REALTIME).
Could there be other queryable types in the future (or even now that I may have missed)?. If not, then I guess with the boolean, we just miss out on option (c) above.
Please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org