[PATCH] pre 1.5 api bug, bad array allocation.

[Martin Hauner <ma...@gmx.net>]

Hi,

here is a small patch fixing a bad array allocation in 1.5 in the pre
1.5 commit api. Since we are pushing pointers into the array, we should give
it the pointer size and not the struct size. The old code inserts the pointer
elements in a distance of 28 bytes.

I also changed a wrong parameter for log_msg_func2, at least it looks wrong
to me. I'm still running the log_msg_func code so i didn't step through that
path.

Good Night.. :)

[[
Fixed pre 1.5 api compatibility bug.

* subversion/libsvn_client/commit_util.c
   (svn_client__get_log_msg): fixed array allocation with item struct
   size instead of pointer size. Corrected wrong parameter in method
   call.
]]


-- 
Martin

Subcommander 2.0.0 Beta 3, 1.2.4 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.

Re: [PATCH] pre 1.5 api bug, bad array allocation.

[Karl Fogel <kf...@red-bean.com>]

Martin Hauner <ma...@gmx.net> writes:
> here is a small patch fixing a bad array allocation in 1.5 in the pre
> 1.5 commit api. Since we are pushing pointers into the array, we should give
> it the pointer size and not the struct size. The old code inserts the pointer
> elements in a distance of 28 bytes.
>
> I also changed a wrong parameter for log_msg_func2, at least it looks wrong
> to me. I'm still running the log_msg_func code so i didn't step through that
> path.

Thanks for fixing these -- committed in r31944, and nominated for
backport to 1.5.1.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org