You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ga...@apache.org on 2023/11/03 04:17:10 UTC
(doris) branch master updated: [test](coverage) Improve test coverage for runtime filter (#26314)
This is an automated email from the ASF dual-hosted git repository.
gabriellee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3d403b061c7 [test](coverage) Improve test coverage for runtime filter (#26314)
3d403b061c7 is described below
commit 3d403b061c718137d108a3a1e7f07104d2a89754
Author: Gabriel <ga...@gmail.com>
AuthorDate: Fri Nov 3 12:17:03 2023 +0800
[test](coverage) Improve test coverage for runtime filter (#26314)
---
be/src/vec/exec/runtime_filter_consumer.h | 1 -
be/src/vec/exprs/vruntimefilter_wrapper.cpp | 11 -----------
be/src/vec/exprs/vruntimefilter_wrapper.h | 2 --
3 files changed, 14 deletions(-)
diff --git a/be/src/vec/exec/runtime_filter_consumer.h b/be/src/vec/exec/runtime_filter_consumer.h
index fcb6ed3c839..ead8ae4fc1e 100644
--- a/be/src/vec/exec/runtime_filter_consumer.h
+++ b/be/src/vec/exec/runtime_filter_consumer.h
@@ -54,7 +54,6 @@ protected:
// For runtime filters
struct RuntimeFilterContext {
- RuntimeFilterContext() : apply_mark(false), runtime_filter(nullptr) {}
RuntimeFilterContext(IRuntimeFilter* rf) : apply_mark(false), runtime_filter(rf) {}
// set to true if this runtime filter is already applied to vconjunct_ctx_ptr
bool apply_mark;
diff --git a/be/src/vec/exprs/vruntimefilter_wrapper.cpp b/be/src/vec/exprs/vruntimefilter_wrapper.cpp
index 1d498f61000..968bad5fedb 100644
--- a/be/src/vec/exprs/vruntimefilter_wrapper.cpp
+++ b/be/src/vec/exprs/vruntimefilter_wrapper.cpp
@@ -47,13 +47,6 @@ namespace doris::vectorized {
VRuntimeFilterWrapper::VRuntimeFilterWrapper(const TExprNode& node, const VExprSPtr& impl)
: VExpr(node), _impl(impl), _always_true(false), _filtered_rows(0), _scan_rows(0) {}
-VRuntimeFilterWrapper::VRuntimeFilterWrapper(const VRuntimeFilterWrapper& vexpr)
- : VExpr(vexpr),
- _impl(vexpr._impl),
- _always_true(vexpr._always_true),
- _filtered_rows(vexpr._filtered_rows.load()),
- _scan_rows(vexpr._scan_rows.load()) {}
-
Status VRuntimeFilterWrapper::prepare(RuntimeState* state, const RowDescriptor& desc,
VExprContext* context) {
RETURN_IF_ERROR_OR_PREPARED(_impl->prepare(state, desc, context));
@@ -71,10 +64,6 @@ void VRuntimeFilterWrapper::close(VExprContext* context,
_impl->close(context, scope);
}
-bool VRuntimeFilterWrapper::is_constant() const {
- return _impl->is_constant();
-}
-
Status VRuntimeFilterWrapper::execute(VExprContext* context, Block* block, int* result_column_id) {
if (_always_true) {
auto res_data_column = ColumnVector<UInt8>::create(block->rows(), 1);
diff --git a/be/src/vec/exprs/vruntimefilter_wrapper.h b/be/src/vec/exprs/vruntimefilter_wrapper.h
index 288ad831a73..642e669288f 100644
--- a/be/src/vec/exprs/vruntimefilter_wrapper.h
+++ b/be/src/vec/exprs/vruntimefilter_wrapper.h
@@ -45,14 +45,12 @@ class VRuntimeFilterWrapper final : public VExpr {
public:
VRuntimeFilterWrapper(const TExprNode& node, const VExprSPtr& impl);
- VRuntimeFilterWrapper(const VRuntimeFilterWrapper& vexpr);
~VRuntimeFilterWrapper() override = default;
Status execute(VExprContext* context, Block* block, int* result_column_id) override;
Status prepare(RuntimeState* state, const RowDescriptor& desc, VExprContext* context) override;
Status open(RuntimeState* state, VExprContext* context,
FunctionContext::FunctionStateScope scope) override;
std::string debug_string() const override { return _impl->debug_string(); }
- bool is_constant() const override;
void close(VExprContext* context, FunctionContext::FunctionStateScope scope) override;
const std::string& expr_name() const override;
const VExprSPtrs& children() const override { return _impl->children(); }
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org