You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2025/10/01 17:26:28 UTC
[PR] NIFI-15018 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundles nifi-email-bundle, nifi-enrich-bundle, nifi-evtx-bundle, nifi-extension-utils and nifi-flow-registry-client-bundle. [nifi]
dan-s1 opened a new pull request, #10362:
URL: https://github.com/apache/nifi/pull/10362
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-15018](https://issues.apache.org/jira/browse/NIFI-15018)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15018 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundles nifi-email-bundle, nifi-enrich-bundle, nifi-evtx-bundle, nifi-extension-utils and nifi-flow-registry-client-bundle. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10362:
URL: https://github.com/apache/nifi/pull/10362#discussion_r2403199834
##########
nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java:
##########
@@ -21,10 +21,13 @@
import org.apache.nifi.processor.util.StandardValidators;
public class JdbcProperties {
+ public static final String OLD_NORMALIZE_NAMES_FOR_AVRO_PROPERTY_NAME = "dbf-normalize";
+ public static final String OLD_USE_AVRO_LOGICAL_TYPES_PROPERTY_NAME = "dbf-user-logical-types";
+ public static final String OLD_DEFAULT_PRECISION_PROPERTY_NAME = "dbf-default-precision";
+ public static final String OLD_DEFAULT_SCALE_PROPERTY_NAME = "dbf-default-scale";
public static final PropertyDescriptor NORMALIZE_NAMES_FOR_AVRO = new PropertyDescriptor.Builder()
- .name("dbf-normalize")
- .displayName("Normalize Table/Column Names")
+ .name("Normalize Table/Column Names")
Review Comment:
```suggestion
.name("Normalize Table and Column Names")
```
##########
nifi-extension-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java:
##########
@@ -120,35 +115,31 @@ abstract class AbstractEmailProcessor<T extends AbstractMailReceiver> extends Ab
.sensitive(true)
.build();
public static final PropertyDescriptor FOLDER = new PropertyDescriptor.Builder()
- .name("folder")
- .displayName("Folder")
+ .name("Folder")
.description("Email folder to retrieve messages from (e.g., INBOX)")
.required(true)
.expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
.defaultValue("INBOX")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
public static final PropertyDescriptor FETCH_SIZE = new PropertyDescriptor.Builder()
- .name("fetch.size")
- .displayName("Fetch Size")
+ .name("Fetch Size")
.description("Specify the maximum number of Messages to fetch per call to Email Server.")
.required(true)
.expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
.defaultValue("10")
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.build();
public static final PropertyDescriptor SHOULD_DELETE_MESSAGES = new PropertyDescriptor.Builder()
- .name("delete.messages")
- .displayName("Delete Messages")
+ .name("Delete Messages")
.description("Specify whether mail messages should be deleted after retrieval.")
.required(true)
.allowableValues("true", "false")
.defaultValue("false")
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
static final PropertyDescriptor CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
- .name("connection.timeout")
- .displayName("Connection timeout")
+ .name("Connection timeout")
Review Comment:
```suggestion
.name("Connection Timeout")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FetchFileTransfer.java:
##########
@@ -116,8 +117,7 @@ public abstract class FetchFileTransfer extends AbstractProcessor {
.build();
public static final PropertyDescriptor FILE_NOT_FOUND_LOG_LEVEL = new PropertyDescriptor.Builder()
- .displayName("Log level when file not found")
- .name("fetchfiletransfer-notfound-loglevel")
+ .name("Log level when file not found")
Review Comment:
```suggestion
.name("Log Level When File Not Found")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DBCPProperties.java:
##########
@@ -134,8 +140,7 @@ private DBCPProperties() {
.build();
public static final PropertyDescriptor MAX_CONN_LIFETIME = new PropertyDescriptor.Builder()
- .displayName("Max Connection Lifetime")
- .name("dbcp-max-conn-lifetime")
+ .name("Max Connection Lifetime")
Review Comment:
```suggestion
.name("Maximum Connection Lifetime")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##########
@@ -138,14 +138,16 @@ default String getAbsolutePath(FlowFile flowFile, String remotePath) throws IOEx
.defaultValue("false")
.allowableValues("true", "false")
.build();
+
+ String OLD_FOLLOW_SYMLINK_PROPERTY_NAME = "follow-symlink";
+
PropertyDescriptor FOLLOW_SYMLINK = new PropertyDescriptor.Builder()
- .name("follow-symlink")
- .displayName("Follow symlink")
- .description("If true, will pull even symbolic files and also nested symbolic subdirectories; otherwise, will not read symbolic files and will not traverse symbolic link subdirectories")
- .required(true)
- .defaultValue("false")
- .allowableValues("true", "false")
- .build();
+ .name("Follow symlink")
Review Comment:
```suggestion
.name("Follow Symbolic Links")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-event-listen/src/main/java/org/apache/nifi/processor/util/listen/ListenerProperties.java:
##########
@@ -122,8 +125,7 @@ public class ListenerProperties {
.required(true)
.build();
public static final PropertyDescriptor WORKER_THREADS = new PropertyDescriptor.Builder()
- .name("Max Number of TCP Connections")
- .displayName("Max Number of Worker Threads")
+ .name("Max Number of Worker Threads")
Review Comment:
Aligning with other components, let's rename this:
```suggestion
.name("Worker Threads")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-hadoop-record-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractPutHDFSRecord.java:
##########
@@ -87,32 +86,28 @@ public abstract class AbstractPutHDFSRecord extends AbstractHadoopProcessor {
.build();
public static final PropertyDescriptor UMASK = new PropertyDescriptor.Builder()
- .name("permissions-umask")
- .displayName("Permissions umask")
+ .name("Permissions umask")
Review Comment:
```suggestion
.name("Permissions Umask")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DBCPProperties.java:
##########
@@ -101,8 +110,7 @@ private DBCPProperties() {
.build();
public static final PropertyDescriptor VALIDATION_QUERY = new PropertyDescriptor.Builder()
- .name("Validation-query")
- .displayName("Validation query")
+ .name("Validation query")
Review Comment:
```suggestion
.name("Validation Query")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DBCPProperties.java:
##########
@@ -69,8 +79,7 @@ private DBCPProperties() {
.build();
public static final PropertyDescriptor DB_DRIVER_LOCATION = new PropertyDescriptor.Builder()
- .name("database-driver-locations")
- .displayName("Database Driver Location(s)")
+ .name("Database Driver Location(s)")
Review Comment:
```suggestion
.name("Database Driver Locations")
```
##########
nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DBCPProperties.java:
##########
@@ -123,8 +130,7 @@ private DBCPProperties() {
.build();
public static final PropertyDescriptor MAX_IDLE = new PropertyDescriptor.Builder()
- .displayName("Max Idle Connections")
- .name("dbcp-max-idle-conns")
+ .name("Max Idle Connections")
Review Comment:
```suggestion
.name("Maximum Idle Connections")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15018 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundles nifi-email-bundle, nifi-enrich-bundle, nifi-evtx-bundle, nifi-extension-utils and nifi-flow-registry-client-bundle. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10362:
URL: https://github.com/apache/nifi/pull/10362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org