You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/12/13 16:20:00 UTC
[jira] [Commented] (HIVE-18661) CachedStore: Use metastore
notification log events to update cache
[ https://issues.apache.org/jira/browse/HIVE-18661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720357#comment-16720357 ]
Hive QA commented on HIVE-18661:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 8s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 5s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 48s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 25s{color} | {color:blue} hcatalog/server-extensions in master has 3 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s{color} | {color:red} ql: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s{color} | {color:red} itests/hive-unit: The patch generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 10s{color} | {color:red} standalone-metastore/metastore-server generated 3 new + 188 unchanged - 0 fixed = 191 total (was 188) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 18s{color} | {color:red} standalone-metastore_metastore-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 18s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | Load of known null value in org.apache.hadoop.hive.metastore.cache.CachedStore.get_aggr_stats_for(String, String, String, List, List, String) At CachedStore.java:in org.apache.hadoop.hive.metastore.cache.CachedStore.get_aggr_stats_for(String, String, String, List, List, String) At CachedStore.java:[line 2226] |
| | Load of known null value in org.apache.hadoop.hive.metastore.cache.CachedStore.updateStatsForTable(RawStore, Table, Table, String, String, String) At CachedStore.java:in org.apache.hadoop.hive.metastore.cache.CachedStore.updateStatsForTable(RawStore, Table, Table, String, String, String) At CachedStore.java:[line 239] |
| | Redundant nullcheck of colStats which is known to be null in org.apache.hadoop.hive.metastore.cache.CachedStore.updateStatsForTable(RawStore, Table, Table, String, String, String) Redundant null check at CachedStore.java:is known to be null in org.apache.hadoop.hive.metastore.cache.CachedStore.updateStatsForTable(RawStore, Table, Table, String, String, String) Redundant null check at CachedStore.java:[line 239] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15299/dev-support/hive-personality.sh |
| git revision | master / b5b6371 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus/diff-checkstyle-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus/diff-checkstyle-itests_hive-unit.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus/whitespace-eol.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus/new-findbugs-standalone-metastore_metastore-server.html |
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-server.txt |
| modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server ql hcatalog/server-extensions itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15299/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> CachedStore: Use metastore notification log events to update cache
> ------------------------------------------------------------------
>
> Key: HIVE-18661
> URL: https://issues.apache.org/jira/browse/HIVE-18661
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Vaibhav Gumashta
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-18661.02.patch, HIVE-18661.03.patch, HIVE-18661.04.patch, HIVE-18661.05.patch, HIVE-18661.06.patch, HIVE-18661.07.patch, HIVE-18661.08.patch
>
>
> Currently, a background thread updates the entire cache which is pretty inefficient. We capture the updates to metadata in NOTIFICATION_LOG table which is getting used in the Replication work. We should have the background thread apply these notifications to incrementally update the cache.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)