You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/22 12:57:18 UTC

[GitHub] [netbeans] dbalek opened a new pull request #2774: [GR-29499] Fixing bug in updaing the list of discovered tests.

dbalek opened a new pull request #2774:
URL: https://github.com/apache/netbeans/pull/2774


   - Fixing bug in updaing the list of discovered tests.
   - Fixing fails in ServerTest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek commented on a change in pull request #2774: [GR-29499] Fixing bug in updaing the list of discovered tests.

Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #2774:
URL: https://github.com/apache/netbeans/pull/2774#discussion_r580429089



##########
File path: java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
##########
@@ -750,7 +752,12 @@ public void publishDiagnostics(PublishDiagnosticsParams params) {
             }
 
             @Override
-            public void showMessage(MessageParams arg0) {
+            public void showMessage(MessageParams params) {
+                if (Server.INDEXING_COMPLETED.equals(params.getMessage())) {
+                    indexingComplete.countDown();
+                } else {
+                    throw new UnsupportedOperationException("Unexpected message.");

Review comment:
       It behaves in the same way as the rest of the tests here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on a change in pull request #2774: [GR-29499] Fixing bug in updaing the list of discovered tests.

Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2774:
URL: https://github.com/apache/netbeans/pull/2774#discussion_r580342290



##########
File path: java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
##########
@@ -750,7 +752,12 @@ public void publishDiagnostics(PublishDiagnosticsParams params) {
             }
 
             @Override
-            public void showMessage(MessageParams arg0) {
+            public void showMessage(MessageParams params) {
+                if (Server.INDEXING_COMPLETED.equals(params.getMessage())) {
+                    indexingComplete.countDown();
+                } else {
+                    throw new UnsupportedOperationException("Unexpected message.");

Review comment:
       Is it necessary to be this strict ? If some code attempts to e.g. `StatusDisplayer` just to note something, this test will fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek merged pull request #2774: [GR-29499] Fixing bug in updaing the list of discovered tests.

Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #2774:
URL: https://github.com/apache/netbeans/pull/2774


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists