You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/12 15:23:06 UTC
[GitHub] [rocketmq-site] mxsm opened a new pull request, #439: [ISSUE #379]Translation for "数据集成-快速开始" Section in the v4.x & 5.0 Document (CN -> EN)
mxsm opened a new pull request, #439:
URL: https://github.com/apache/rocketmq-site/pull/439
Please do not create a Pull Request without creating an issue first.
## What is the purpose of the change
close #379
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] Oliverwqcwrw merged pull request #439: [ISSUE #379]Translation for "数据集成-快速开始" Section in the v4.x & 5.0 Document (CN -> EN)
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw merged PR #439:
URL: https://github.com/apache/rocketmq-site/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] Oliverwqcwrw commented on a diff in pull request #439: [ISSUE #379]Translation for "数据集成-快速开始" Section in the v4.x & 5.0 Document (CN -> EN)
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #439:
URL: https://github.com/apache/rocketmq-site/pull/439#discussion_r1069137799
##########
i18n/en/docusaurus-plugin-content-docs/version-5.0/08-数据集成/27RocketMQ Connect Quick Start.md:
##########
@@ -95,68 +95,70 @@ cat test-sink-file.txt
> tail -100f ~/logs/rocketmqconnect/connect_runtime.log
-看到以下日志说明file sink connector 启动成功了
+If you see the following log message, it means the file sink connector has started successfully.
> 2019-07-16 11:24:58 INFO pool-7-thread-2 - **Sink task start**, config:{"properties":{"source-record-...
-如果 test-sink-file.txt 生成并且与 source-file.txt 内容一样，说明整个流程正常运行。
-文件内容可能顺序不一样，这主要是因为RocketMQ发到不同queue时，接收不同queue消息顺序可能也不一致导致的，是正常的。
+If test-sink-file.txt is generated and its content is the same as source-file.txt, it means that the entire process is running normally.
+
+The file contents may be in a different order, which is normal because the order of messages received from different queues in RocketMQ may also be inconsistent.
-#### sink connector配置说明
+#### sink connector configuration instructions
-| key | nullable | default | description |
-|--------------------| -------- | ------- | -------------------------------------------------------------------------------------- |
-| connector.class | false | | 实现Connector接口的类名称（包含包名） |
-| filename | false | | sink拉去的数据保存到文件 |
-| connect.topicnames | false | | sink需要处理数据消息topics |
+| key | nullable | default | description |
+| ------------------ | -------- | ------- | ------------------------------------------------------------ |
+| connector.class | false | | The class name (including the package name) that implements the Connector interface |
+| filename | false | | The sink pulls data and saves it to a file. |
+| connect.topicnames | false | | The topics of the data messages that the sink needs to process. |
```
-注：source/sink配置文件说明是以rocketmq-connect-sample为demo，不同source/sink connector配置有差异，请以具体sourc/sink connector 为准
+注：The configuration file instructions for the sample rocketmq-connect-sample are for reference only, different source/sink connectors have different configurations, please refer to the specific source/sink connector.
Review Comment:
```suggestion
tips：The configuration file instructions for the sample rocketmq-connect-sample are for reference only, different source/sink connectors have different configurations, please refer to the specific source/sink connector.
```
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] Oliverwqcwrw commented on a diff in pull request #439: [ISSUE #379]Translation for "数据集成-快速开始" Section in the v4.x & 5.0 Document (CN -> EN)
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #439:
URL: https://github.com/apache/rocketmq-site/pull/439#discussion_r1069134390
##########
i18n/en/docusaurus-plugin-content-docs/current/08-数据集成/27RocketMQ Connect Quick Start.md:
##########
@@ -95,68 +95,70 @@ cat test-sink-file.txt
> tail -100f ~/logs/rocketmqconnect/connect_runtime.log
-看到以下日志说明file sink connector 启动成功了
+If you see the following log message, it means the file sink connector has started successfully.
> 2019-07-16 11:24:58 INFO pool-7-thread-2 - **Sink task start**, config:{"properties":{"source-record-...
-如果 test-sink-file.txt 生成并且与 source-file.txt 内容一样，说明整个流程正常运行。
-文件内容可能顺序不一样，这主要是因为RocketMQ发到不同queue时，接收不同queue消息顺序可能也不一致导致的，是正常的。
+If test-sink-file.txt is generated and its content is the same as source-file.txt, it means that the entire process is running normally.
+
+The file contents may be in a different order, which is normal because the order of messages received from different queues in RocketMQ may also be inconsistent.
-#### sink connector配置说明
+#### sink connector configuration instructions
-| key | nullable | default | description |
-|--------------------| -------- | ------- | -------------------------------------------------------------------------------------- |
-| connector.class | false | | 实现Connector接口的类名称（包含包名） |
-| filename | false | | sink拉去的数据保存到文件 |
-| connect.topicnames | false | | sink需要处理数据消息topics |
+| key | nullable | default | description |
+| ------------------ | -------- | ------- | ------------------------------------------------------------ |
+| connector.class | false | | The class name (including the package name) that implements the Connector interface |
+| filename | false | | The sink pulls data and saves it to a file. |
+| connect.topicnames | false | | The topics of the data messages that the sink needs to process. |
```
-注：source/sink配置文件说明是以rocketmq-connect-sample为demo，不同source/sink connector配置有差异，请以具体sourc/sink connector 为准
+注：The configuration file instructions for the sample rocketmq-connect-sample are for reference only, different source/sink connectors have different configurations, please refer to the specific source/sink connector.
Review Comment:
```suggestion
tips：The configuration file instructions for the sample rocketmq-connect-sample are for reference only, different source/sink connectors have different configurations, please refer to the specific source/sink connector.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] mxsm commented on a diff in pull request #439: [ISSUE #379]Translation for "数据集成-快速开始" Section in the v4.x & 5.0 Document (CN -> EN)
Posted by GitBox <gi...@apache.org>.
mxsm commented on code in PR #439:
URL: https://github.com/apache/rocketmq-site/pull/439#discussion_r1069162313
##########
i18n/en/docusaurus-plugin-content-docs/current/08-数据集成/27RocketMQ Connect Quick Start.md:
##########
@@ -95,68 +95,70 @@ cat test-sink-file.txt
> tail -100f ~/logs/rocketmqconnect/connect_runtime.log
-看到以下日志说明file sink connector 启动成功了
+If you see the following log message, it means the file sink connector has started successfully.
> 2019-07-16 11:24:58 INFO pool-7-thread-2 - **Sink task start**, config:{"properties":{"source-record-...
-如果 test-sink-file.txt 生成并且与 source-file.txt 内容一样，说明整个流程正常运行。
-文件内容可能顺序不一样，这主要是因为RocketMQ发到不同queue时，接收不同queue消息顺序可能也不一致导致的，是正常的。
+If test-sink-file.txt is generated and its content is the same as source-file.txt, it means that the entire process is running normally.
+
+The file contents may be in a different order, which is normal because the order of messages received from different queues in RocketMQ may also be inconsistent.
-#### sink connector配置说明
+#### sink connector configuration instructions
-| key | nullable | default | description |
-|--------------------| -------- | ------- | -------------------------------------------------------------------------------------- |
-| connector.class | false | | 实现Connector接口的类名称（包含包名） |
-| filename | false | | sink拉去的数据保存到文件 |
-| connect.topicnames | false | | sink需要处理数据消息topics |
+| key | nullable | default | description |
+| ------------------ | -------- | ------- | ------------------------------------------------------------ |
+| connector.class | false | | The class name (including the package name) that implements the Connector interface |
+| filename | false | | The sink pulls data and saves it to a file. |
+| connect.topicnames | false | | The topics of the data messages that the sink needs to process. |
```
-注：source/sink配置文件说明是以rocketmq-connect-sample为demo，不同source/sink connector配置有差异，请以具体sourc/sink connector 为准
+注：The configuration file instructions for the sample rocketmq-connect-sample are for reference only, different source/sink connectors have different configurations, please refer to the specific source/sink connector.
Review Comment:
@Oliverwqcwrw I will fix it and re-submit later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org