You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/30 18:41:42 UTC

[GitHub] [spark] rdblue commented on a change in pull request #30554: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE command

rdblue commented on a change in pull request #30554:
URL: https://github.com/apache/spark/pull/30554#discussion_r532817212



##########
File path: docs/sql-migration-guide.md
##########
@@ -54,6 +54,8 @@ license: |
   
   - In Spark 3.1, creating or altering a view will capture runtime SQL configs and store them as view properties. These configs will be applied during the parsing and analysis phases of the view resolution. To restore the behavior before Spark 3.1, you can set `spark.sql.legacy.useCurrentConfigsForView` to `true`.
 
+  - In Spark 3.1, `CREATE TABLE` without a specific table provider uses the value of `spark.sql.sources.default` as its table provider. In Spark version 3.0 and below, it was Hive. To restore the behavior before Spark 3.1, you can set `spark.sql.legacy.createHiveTableByDefault.enabled` to `true`.

Review comment:
       I don't think that the default behavior of `CREATE TABLE` should change in a point release. Why is this considered a "safe" change to make?
   
   This could easily break existing workflows and should be done in a major release.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org