You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "guluo2016 (via GitHub)" <gi...@apache.org> on 2025/03/08 06:36:16 UTC
[PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
guluo2016 opened a new pull request, #3950:
URL: https://github.com/apache/ambari/pull/3950
## What changes were proposed in this pull request?
Issue details see: [AMBARI-26309](https://issues.apache.org/jira/browse/AMBARI-26309)
There are several changes in this PR, as following.
1. Upgrade eclipselink to 4.0.5.
This change mainly solves the problem of long-time hanging when starting ambari-server.
This issue does exists in eclipselink 2.7.14, issue details see: https://github.com/eclipse-ee4j/eclipselink/issues/2075
And this issue was fixed in eclipselink 2.7.14, details see: https://github.com/eclipse-ee4j/eclipselink/pull/2335
2. Upgrade to JPA 3.x
eclipselink 4.x follows JPA 3.x specification.
And an important change in JPA 3 is the change in package names, from javax.persistence to jakarta.persistence.
So, I have added the jakarta.persistence-api-3.1.0 to ambari project, and update package name from javax.persistence to jakarta.persistence.
3. Upgrade guice to 7.0.0
The reason： guice didnot add support for jakarta.inject until version 7.0.0, issue details see: https://github.com/google/guice/issues/1383, and Guice 7.0.0 changes see: https://github.com/google/guice/wiki/Guice700#:~:text=JEE%20Jakarta%20Transition,7.0%20are%20identical
## How was this patch tested?
I have already manually tested it, amabri-server can start and run normally.
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 closed pull request #3950: AMBARI-26309: Ambari server takes up about an hour to start
URL: https://github.com/apache/ambari/pull/3950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3950:
URL: https://github.com/apache/ambari/pull/3950#issuecomment-2709253958
@guluo2016 The issues encountered in your PR have already been addressed and fixed in the Spring 6 upgrade branch. This is a duplicate submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
Posted by "nikita15p (via GitHub)" <gi...@apache.org>.
nikita15p commented on code in PR #3950:
URL: https://github.com/apache/ambari/pull/3950#discussion_r1988821384
##########
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java:
##########
@@ -20,13 +20,13 @@
import java.util.Objects;
-import javax.inject.Inject;
-
import org.apache.ambari.server.AmbariException;
import org.apache.ambari.server.agent.stomp.dto.Hashable;
import org.apache.ambari.server.events.STOMPEvent;
import org.apache.ambari.server.events.publishers.STOMPUpdatePublisher;
+import com.google.inject.Inject;
Review Comment:
Can this change be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on PR #3950:
URL: https://github.com/apache/ambari/pull/3950#issuecomment-2746043415
Thank you for your reminder. I have seen the relevant PR , so this PR will be closed.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26309: Ambari server takes up about an hour to start [ambari]
Posted by "nikita15p (via GitHub)" <gi...@apache.org>.
nikita15p commented on code in PR #3950:
URL: https://github.com/apache/ambari/pull/3950#discussion_r1988821384
##########
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java:
##########
@@ -20,13 +20,13 @@
import java.util.Objects;
-import javax.inject.Inject;
-
import org.apache.ambari.server.AmbariException;
import org.apache.ambari.server.agent.stomp.dto.Hashable;
import org.apache.ambari.server.events.STOMPEvent;
import org.apache.ambari.server.events.publishers.STOMPUpdatePublisher;
+import com.google.inject.Inject;
Review Comment:
Can this change be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org