[GitHub] rymanluk commented on a change in pull request #181: nimble/ll: Certification fixes - part 2

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #181: nimble/ll: Certification fixes - part 2
URL: https://github.com/apache/mynewt-nimble/pull/181#discussion_r218717335
 
 

 ##########
 File path: nimble/controller/src/ble_ll_conn_hci.c
 ##########
 @@ -850,8 +850,11 @@ ble_ll_conn_hci_update(uint8_t *cmdbuf)
         return BLE_ERR_CMD_DISALLOWED;
     }
 
-    /* See if this feature is supported on both sides */
-    if ((connsm->conn_features & BLE_LL_FEAT_CONN_PARM_REQ) == 0) {
+    /* See if this feature is supported on both sides.
+     * If features has not be exchanged let us give a try and send request
+     */
+    if (connsm->conn_features &&
+        (connsm->conn_features & BLE_LL_FEAT_CONN_PARM_REQ) == 0) {
 
 Review comment:
   well this patch is indeed not needed as our controller always does feature exchange. Will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services