You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nlivens <gi...@git.apache.org> on 2015/08/27 14:59:18 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/756
CLOUDSTACK-8781 : Superfluous field during VPC creation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-8781
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #756
----
commit b1f1b63e28a09503f690fa504ed4861d7a518a67
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2015-08-27T12:57:17Z
CLOUDSTACK-8781 : Superfluous field during VPC creation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-138889654
Hi @nlivens
Okay... I will have a look at the code. Very weird to have it there and not use it. :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-137691079
As @DaanHoogland suggested, if one should not see the Netscaler option, then I fix should be put in place where a condition is checked and upon that the drop-box will be showed or not.
The PR should not be merged with the fix it contains because it will remove the Netscaler support for VPCs form the UI, making it possible only via API/CloudMonkey
:-1:
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/756
@rhtyd Here are the screen-shots without and with this UI bug fix:
As pointed out by @nlivens in the previous comment, "The actual Public Load Balancer provider is derived from the VPC offering, and not from this extra field "Public Load Balancer Provider". So, this field has no use at all since it's completely ignored."
The cleaner implementation for this UI tab would be to only list "Public Load Balancer Providers" mentioned in the selected VPC offering. Moreover, don't show this tab, if there are no "Public Load Balancer Providers" being mentioned in the selected VPC offering. Finally, make use of the selected "Public Load Balancer Provider" in the actual implementation of the VPC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136620633
@wilderrodrigues, @DaanHoogland, I removed the field since it's not used at all in the code.
No matter what you select in that dropdown, the value will be ignored. Therefore I thought it would be good to just remove the field since it can only create confusion for the users. That's the only reason for this PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/756
Thanks, merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136449843
@wilderrodrigues I agree. @nlivens maybe a conditional display can be concocted. I suppose you made this because the dropdown was hindering your eyesight..?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #756: CLOUDSTACK-8781 : Superfluous field during VPC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216187288
@nlivens please rebase against latest master and push -f
LGTM, the removed code (publicLoadBalancerProvider key) is not referenced in any of the actions or dataProviders to create and send the `data` payload
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-137720078
@wilderrodrigues, this change doesn't remove the Netscaler support for VPCs from the UI. The actual Public Load Balancer provider is derived from the VPC offering, and not from this extra field "Public Load Balancer Provider". So, this field has no use at all since it's completely ignored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/756
@rhtyd, rebased against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216208745
@rhtyd, rebased against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136397028
Hi @nlivens ,
I'm looking int your PR and also and some documentation of Cloudstack 4.2 related to Netscaler as external load balancer for VPCs:
The implementation was done in this issue: https://issues.apache.org/jira/browse/CLOUDSTACK-869
The documentation can be found here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+%3A+Support+of+Netscaler+as+External+LoadBalancing+Provider+in+VPC
And if it should be removed, I believe it wouldn't be only about the Netscaler option, but also the offering - as showed in the image below:
So, unless I misunderstood something, this PR should not be applied.
@bhaisaab @remibergsma @DaanHoogland could one of you please give some thought on this PR and on what I wrote?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the issue:
https://github.com/apache/cloudstack/pull/756
### ACS CI BVT Run
**Sumarry:**
Build Number 132
Hypervisor xenserver
NetworkType Advanced
Passed=70
Failed=1
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_service_offerings.py
* ContextSuite context=TestServiceOfferings>:setup Failing since 7 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/756
I'm not sure about the changes, but if the mentioned field is not consumed anywhere, it LGTM. Can we have a manual UI screenshot to confirm changes since this is a pure UI change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---