You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2016/05/15 20:28:03 UTC
[math] MATH-1357
Repository: commons-math
Updated Branches:
refs/heads/develop 1325484c3 -> 4a31885cc
MATH-1357
Additional info on how to contribute.
Thanks to Rob Tompkins.
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/4a31885c
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/4a31885c
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/4a31885c
Branch: refs/heads/develop
Commit: 4a31885cc00ba7382f4c47f735c5fda88f14a15f
Parents: 1325484
Author: Gilles <gi...@harfang.homelinux.org>
Authored: Sun May 15 22:18:40 2016 +0200
Committer: Gilles <gi...@harfang.homelinux.org>
Committed: Sun May 15 22:18:40 2016 +0200
----------------------------------------------------------------------
CONTRIBUTING.md | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-math/blob/4a31885c/CONTRIBUTING.md
----------------------------------------------------------------------
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 5bcbfc1..c68f4bc 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -59,13 +59,18 @@ Getting Started
Making Changes
--------------
-+ Create a topic branch from where you want to base your work (this is usually the master/trunk branch).
++ Create a topic branch from where you want to base your work (this is usually the develop/trunk branch).
+ Make commits of logical units.
+ Respect the original code style:
+ Only use spaces for indentation.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
+ Check for unnecessary whitespace with git diff --check before committing.
++ Topic branch names should directly correspond to the JIRA issues they are intended to resolve. For example branch names should look like:
+ + `improvement-MATH-852`
+ + `bug-MATH-1329`
+ + `feature-MATH-621`
+ Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
+ + For example, a commit message might look like `MATH-852: Adding documentation for development`
+ Make sure you have added the necessary tests for your changes.
+ Run all the tests with `mvn clean verify` to assure nothing else was accidentally broken.