[GitHub] [spark] cloud-fan commented on a change in pull request #35250: [SPARK-37961][SQL] Override maxRows/maxRowsPerPartition for some logical operators

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35250:
URL: https://github.com/apache/spark/pull/35250#discussion_r810848899



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -1344,7 +1360,13 @@ case class Sample(
       s"Sampling fraction ($fraction) must be on interval [0, 1] without replacement")
   }
 
-  override def maxRows: Option[Long] = child.maxRows

Review comment:
       interesting, cc @sigmod @maryannxue @srielau 
   
   this seems like a correctness issue and we should fix it ASAP. @zhengruifeng can you open a new PR for the sample fix only so that we can backport?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org