You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/07/14 03:43:13 UTC
Re: svn commit: r1146492 -
/subversion/trunk/subversion/include/svn_client.h
gstein@apache.org wrote on Wed, Jul 13, 2011 at 21:43:48 -0000:
> Author: gstein
> Date: Wed Jul 13 21:43:48 2011
> New Revision: 1146492
>
> URL: http://svn.apache.org/viewvc?rev=1146492&view=rev
> Log:
> The public API should keep the underlying structures const to disallow
> changing "via" the const svn_client_info2_t.
>
> * include/svn_client.h:
> (svn_client_info2_t): constify the LOCK and WC_INFO members
>
> Modified:
> subversion/trunk/subversion/include/svn_client.h
>
> Modified: subversion/trunk/subversion/include/svn_client.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_client.h?rev=1146492&r1=1146491&r2=1146492&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/include/svn_client.h (original)
> +++ subversion/trunk/subversion/include/svn_client.h Wed Jul 13 21:43:48 2011
> @@ -5388,10 +5388,10 @@ typedef struct svn_client_info2_t
> const char *last_changed_author;
>
> /** An exclusive lock, if present. Could be either local or remote. */
> - svn_lock_t *lock;
> + const svn_lock_t *lock;
>
subversion/libsvn_client/deprecated.c: In function ‘info_from_info2’:
subversion/libsvn_client/deprecated.c:2180: warning: assignment discards qualifiers from pointer target type
Re: svn commit: r1146492 - /subversion/trunk/subversion/include/svn_client.h
Posted by Greg Stein <gs...@gmail.com>.
>> +++ subversion/trunk/subversion/include/svn_client.h Wed Jul 13 21:43:48 2011
>> @@ -5388,10 +5388,10 @@ typedef struct svn_client_info2_t
>> const char *last_changed_author;
>>
>> /** An exclusive lock, if present. Could be either local or remote. */
>> - svn_lock_t *lock;
>> + const svn_lock_t *lock;
>>
>
> subversion/libsvn_client/deprecated.c: In function ‘info_from_info2’:
> subversion/libsvn_client/deprecated.c:2180: warning: assignment discards qualifiers from pointer target type
Thanks. Fixed in r1146555. STATUS updated.