You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/02 09:41:59 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #885: createnetworkform: Displaying api errors
davidjumani opened a new pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885
Shows errors while fetching network offerings. Especially noticeable when there are multiple guest physical networks in a zone but are untagged.
Makes life easier for the user so he knows what's wrong rather than just shown empty dropdowns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-738752315
+1, reverting back to the old user experience is definitely better than the new UX.
Ideally, we'd find a way such that the admin can't get CloudStack networking in that state, but that's not one for today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737121831
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus merged pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
PaulAngus merged pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737714797
@rhtyd It copies the behaviour of the old UI even for regular users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737780550
@rhtyd Changing the error response will require a backend fix. This just copies the old UI functionality so the user knows that an error has occurred trying to create a network (while fetching network offerings). The error is clear for admins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737780550
@rhtyd Changing the error response will require a backend fix. This just copies the old UI functionality so the user knows that an error has occurred trying to create a network (while fetching network offerings)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737122601
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737706151
Could this break previous behaviour @davidjumani, does old UI show any exception? Also is this shown only to admins?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737129251
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/885 (JID-3713)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #885: createnetworkform: Displaying api errors
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #885:
URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737767085
@davidjumani actually the error is not very clear, I'll let @DaanHoogland @PaulAngus advise further on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org