You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ongchi (via GitHub)" <gi...@apache.org> on 2023/02/16 14:06:26 UTC
[GitHub] [arrow-datafusion] ongchi opened a new pull request, #5303: Make SQL query consistent with API syntax expression in code examples
ongchi opened a new pull request, #5303:
URL: https://github.com/apache/arrow-datafusion/pull/5303
# Which issue does this PR close?
This is a minor document fix, does not introduce new features or fix bugs.
# Rationale for this change
Examples are provides for both SQL query and DataFrame API respectively, and they should be semantically consistent.
The DataFrame API example on this page calls `filter` methods on `df`, but the DataFrame API one does not contains relevant part of `WHERE` expression, this could be confusing for newcomers.
# What changes are included in this PR?
This PR adds `WHERE` express to SQL query examples to match API syntax expression.
# Are these changes tested?
Code blocks should covered by doctest.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5303: Make SQL query consistent with API syntax expression in code examples
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5303:
URL: https://github.com/apache/arrow-datafusion/pull/5303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5303: Make SQL query consistent with API syntax expression in code examples
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5303:
URL: https://github.com/apache/arrow-datafusion/pull/5303#issuecomment-1433565381
Benchmark runs are scheduled for baseline = afb73bead31b9b14a387560d23b7162d64edd7a6 and contender = fd75ba461d59bff10adc9c16cead241565c2d2f2. fd75ba461d59bff10adc9c16cead241565c2d2f2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc8949c8708e49abaa273d83f1d89693...85b452bae5134adab74e0c93829c0d9a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/14602a494c0845c5a6fd4c2ed5854b70...7a58a64a91404468a391c80f395733c6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5626649ba64d4616bf6cfaecbd8d82d8...cb8117daf8384717bf1c30dacfe6cbc8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a06f913550af40eab6283f559494baed...38e9d751b74a4f12a498c7f22497c730/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org