You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/27 13:50:11 UTC

[GitHub] [shardingsphere] huangdx0726 opened a new pull request, #19610: fix IllegalStateException for 19449

huangdx0726 opened a new pull request, #19610:
URL: https://github.com/apache/shardingsphere/pull/19610

   Fixes #19449 .
   
   Changes proposed in this pull request:
   -
    fix IllegalStateException occurrd when excute DistSQL SHOW DB_DISCOVERY RULES
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610#issuecomment-1198903780

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19610?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19610](https://codecov.io/gh/apache/shardingsphere/pull/19610?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c340e0c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/01f231180a9b814a0207cb5f12b2edd4a39de10e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01f2311) will **decrease** coverage by `0.16%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19610      +/-   ##
   ============================================
   - Coverage     60.18%   60.01%   -0.17%     
   + Complexity     2397     2390       -7     
   ============================================
     Files          3840     3847       +7     
     Lines         54653    54791     +138     
     Branches       7637     7661      +24     
   ============================================
   - Hits          32891    32882       -9     
   - Misses        18937    19090     +153     
   + Partials       2825     2819       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ler/query/DatabaseDiscoveryRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9EYXRhYmFzZURpc2NvdmVyeVJ1bGVRdWVyeVJlc3VsdFNldC5qYXZh) | `88.00% <100.00%> (+5.39%)` | :arrow_up: |
   | [...e/model/privilege/DatabasePermittedPrivileges.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXV0aG9yaXR5L3Byb3ZpZGVyL2RhdGFiYXNlL21vZGVsL3ByaXZpbGVnZS9EYXRhYmFzZVBlcm1pdHRlZFByaXZpbGVnZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [...source/pool/destroyer/DataSourcePoolDestroyer.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvZGVzdHJveWVyL0RhdGFTb3VyY2VQb29sRGVzdHJveWVyLmphdmE=) | `66.66% <0.00%> (-16.67%)` | :arrow_down: |
   | [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `61.70% <0.00%> (-11.83%)` | :arrow_down: |
   | [...atasource/props/DataSourcePropertiesValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL0RhdGFTb3VyY2VQcm9wZXJ0aWVzVmFsaWRhdG9yLmphdmE=) | `88.00% <0.00%> (-7.66%)` | :arrow_down: |
   | [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `85.71% <0.00%> (-7.15%)` | :arrow_down: |
   | [.../coordinator/ClusterContextManagerCoordinator.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9DbHVzdGVyQ29udGV4dE1hbmFnZXJDb29yZGluYXRvci5qYXZh) | `77.27% <0.00%> (-3.68%)` | :arrow_down: |
   | [...hema/loader/dialect/MySQLSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvTXlTUUxTY2hlbWFNZXRhRGF0YUxvYWRlci5qYXZh) | `72.97% <0.00%> (-3.22%)` | :arrow_down: |
   | [...ema/loader/dialect/OracleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3JhY2xlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `86.25% <0.00%> (-0.50%)` | :arrow_down: |
   | [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9TaGFyZGluZ1J1bGUuamF2YQ==) | `82.63% <0.00%> (ø)` | |
   | ... and [313 more](https://codecov.io/gh/apache/shardingsphere/pull/19610/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huangdx0726 commented on pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

huangdx0726 commented on PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610#issuecomment-1199464732

   I‘v revert the order of imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huangdx0726 commented on pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

huangdx0726 commented on PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610#issuecomment-1198813451

   ok
   
   
   
   ---Original---
   From: ***@***.***&gt;
   Date: Fri, Jul 29, 2022 09:22 AM
   To: ***@***.***&gt;;
   Cc: "Da Xiang ***@***.******@***.***&gt;;
   Subject: Re: [apache/shardingsphere] fix IllegalStateException for 19449 (PR#19610)
   
   
   
   
    
   @huangdx0726 Hello, can you add unit tests for empty rules?
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you were mentioned.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

RaigorJiang merged PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

RaigorJiang commented on PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610#issuecomment-1199429594

   Hi @huangdx0726 
   Thanks for the PR, but why change the order of imports?
   The order you changed is incorrect, please follow the code conduct of ShardingSphere:
   https://shardingsphere.apache.org/community/en/contribute/code-conduct/
   
   If you use IDEA, please import settings, this will better keep the format correct.
   \
   <img width="1133" alt="image" src="https://user-images.githubusercontent.com/5668787/181784371-5f7de971-6074-40ee-89a5-02193586f663.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on pull request #19610: fix IllegalStateException for 19449

Posted by GitBox <gi...@apache.org>.

yx9o commented on PR #19610:
URL: https://github.com/apache/shardingsphere/pull/19610#issuecomment-1198787889

   @huangdx0726 Hello, can you add unit tests for empty rules?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org