You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/09/02 17:09:50 UTC
(superset) branch master updated: chore(lint): scope in-repo eslint plugins under @superset-ui (#43054)
This is an automated email from the ASF dual-hosted git repository.
sadpandajoe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 316f6ad971a chore(lint): scope in-repo eslint plugins under @superset-ui (#43054)
316f6ad971a is described below
commit 316f6ad971a92c15ff8cf6184083a7a4540556d3
Author: K HARSHAVARDHAN <ha...@gmail.com>
AuthorDate: Wed Sep 2 22:39:42 2026 +0530
chore(lint): scope in-repo eslint plugins under @superset-ui (#43054)
---
scripts/check-type.js | 6 ++--
.../eslint-plugin-i18n-strings/package.json | 2 +-
.../eslint-rules/eslint-plugin-icons/package.json | 2 +-
.../eslint-plugin-theme-colors/package.json | 2 +-
superset-frontend/eslint.config.minimal.js | 6 ++--
superset-frontend/package-lock.json | 33 ++++++++++++----------
superset-frontend/package.json | 6 ++--
7 files changed, 30 insertions(+), 27 deletions(-)
diff --git a/scripts/check-type.js b/scripts/check-type.js
index 609b0cb391d..966e483078b 100755
--- a/scripts/check-type.js
+++ b/scripts/check-type.js
@@ -289,11 +289,11 @@ function extractArgs(args, regexes) {
* For example: `superset-frontend/foo/bar.ts` -> `foo/bar.ts`
*
* @param {string[]} args
- * @param {string} package
+ * @param {string} packageName
* @returns {string[]}
*/
-function removePackageSegment(args, package) {
- const packageSegment = package.concat(sep);
+function removePackageSegment(args, packageName) {
+ const packageSegment = packageName.concat(sep);
return args.map((arg) => {
const normalizedPath = normalize(arg);
diff --git a/superset-frontend/eslint-rules/eslint-plugin-i18n-strings/package.json b/superset-frontend/eslint-rules/eslint-plugin-i18n-strings/package.json
index 3f390c0c858..4c532c27175 100644
--- a/superset-frontend/eslint-rules/eslint-plugin-i18n-strings/package.json
+++ b/superset-frontend/eslint-rules/eslint-plugin-i18n-strings/package.json
@@ -1,5 +1,5 @@
{
- "name": "eslint-plugin-i18n-strings",
+ "name": "@superset-ui/eslint-plugin-i18n-strings",
"version": "1.0.0",
"description": "Warns about translation variables",
"keywords": [],
diff --git a/superset-frontend/eslint-rules/eslint-plugin-icons/package.json b/superset-frontend/eslint-rules/eslint-plugin-icons/package.json
index a4d3a818024..fced5fa7e65 100644
--- a/superset-frontend/eslint-rules/eslint-plugin-icons/package.json
+++ b/superset-frontend/eslint-rules/eslint-plugin-icons/package.json
@@ -1,5 +1,5 @@
{
- "name": "eslint-plugin-icons",
+ "name": "@superset-ui/eslint-plugin-icons",
"version": "1.0.0",
"description": "Warns about direct usage of Ant Design icons",
"keywords": [],
diff --git a/superset-frontend/eslint-rules/eslint-plugin-theme-colors/package.json b/superset-frontend/eslint-rules/eslint-plugin-theme-colors/package.json
index 650ddff1f2f..f42959718b2 100644
--- a/superset-frontend/eslint-rules/eslint-plugin-theme-colors/package.json
+++ b/superset-frontend/eslint-rules/eslint-plugin-theme-colors/package.json
@@ -1,5 +1,5 @@
{
- "name": "eslint-plugin-theme-colors",
+ "name": "@superset-ui/eslint-plugin-theme-colors",
"version": "1.0.0",
"description": "Warns about rgb(a)/hex/literal colors",
"keywords": [],
diff --git a/superset-frontend/eslint.config.minimal.js b/superset-frontend/eslint.config.minimal.js
index 7eb2d3b7273..f183d7dae70 100644
--- a/superset-frontend/eslint.config.minimal.js
+++ b/superset-frontend/eslint.config.minimal.js
@@ -37,9 +37,9 @@
require('tsx/cjs');
const tsParser = require('@typescript-eslint/parser');
-const themeColorsPlugin = require('eslint-plugin-theme-colors');
-const iconsPlugin = require('eslint-plugin-icons');
-const i18nStringsPlugin = require('eslint-plugin-i18n-strings');
+const themeColorsPlugin = require('@superset-ui/eslint-plugin-theme-colors');
+const iconsPlugin = require('@superset-ui/eslint-plugin-icons');
+const i18nStringsPlugin = require('@superset-ui/eslint-plugin-i18n-strings');
module.exports = [
// Files this config applies to. Flat config has no `--ext`; globs live here.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index 6e02bf39f7f..2554ced01c9 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -183,6 +183,9 @@
"@storybook/addon-links": "10.5.10",
"@storybook/react-webpack5": "10.5.10",
"@storybook/test-runner": "0.24.4",
+ "@superset-ui/eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
+ "@superset-ui/eslint-plugin-icons": "file:eslint-rules/eslint-plugin-icons",
+ "@superset-ui/eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
"@svgr/webpack": "^8.1.0",
"@swc/core": "^1.16.1",
"@swc/plugin-emotion": "^15.0.0",
@@ -226,8 +229,6 @@
"eslint": "^10.9.0",
"eslint-import-resolver-alias": "^1.1.2",
"eslint-import-resolver-typescript": "^4.4.5",
- "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
- "eslint-plugin-icons": "file:eslint-rules/eslint-plugin-icons",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jest-dom": "^5.10.1",
"eslint-plugin-lodash": "^8.0.0",
@@ -236,7 +237,6 @@
"eslint-plugin-react-you-might-not-need-an-effect": "^1.0.2",
"eslint-plugin-storybook": "10.5.10",
"eslint-plugin-testing-library": "^7.16.2",
- "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
"fetch-mock": "^12.6.0",
"fork-ts-checker-webpack-plugin": "^9.1.0",
"history": "^5.3.0",
@@ -296,6 +296,7 @@
}
},
"eslint-rules/eslint-plugin-i18n-strings": {
+ "name": "@superset-ui/eslint-plugin-i18n-strings",
"version": "1.0.0",
"dev": true,
"license": "Apache-2.0",
@@ -304,6 +305,7 @@
}
},
"eslint-rules/eslint-plugin-icons": {
+ "name": "@superset-ui/eslint-plugin-icons",
"version": "1.0.0",
"dev": true,
"license": "Apache-2.0",
@@ -312,6 +314,7 @@
}
},
"eslint-rules/eslint-plugin-theme-colors": {
+ "name": "@superset-ui/eslint-plugin-theme-colors",
"version": "1.0.0",
"dev": true,
"license": "Apache-2.0"
@@ -11244,6 +11247,18 @@
"resolved": "packages/superset-ui-core",
"link": true
},
+ "node_modules/@superset-ui/eslint-plugin-i18n-strings": {
+ "resolved": "eslint-rules/eslint-plugin-i18n-strings",
+ "link": true
+ },
+ "node_modules/@superset-ui/eslint-plugin-icons": {
+ "resolved": "eslint-rules/eslint-plugin-icons",
+ "link": true
+ },
+ "node_modules/@superset-ui/eslint-plugin-theme-colors": {
+ "resolved": "eslint-rules/eslint-plugin-theme-colors",
+ "link": true
+ },
"node_modules/@superset-ui/generator-superset": {
"resolved": "packages/generator-superset",
"link": true
@@ -20010,14 +20025,6 @@
"ms": "^2.1.1"
}
},
- "node_modules/eslint-plugin-i18n-strings": {
- "resolved": "eslint-rules/eslint-plugin-i18n-strings",
- "link": true
- },
- "node_modules/eslint-plugin-icons": {
- "resolved": "eslint-rules/eslint-plugin-icons",
- "link": true
- },
"node_modules/eslint-plugin-import": {
"version": "2.32.0",
"resolved": "https://registry.npmjs.org/eslint-plugin-import/-/eslint-plugin-import-2.32.0.tgz",
@@ -20241,10 +20248,6 @@
"eslint": "^8.57.0 || ^9.0.0 || ^10.0.0"
}
},
- "node_modules/eslint-plugin-theme-colors": {
- "resolved": "eslint-rules/eslint-plugin-theme-colors",
- "link": true
- },
"node_modules/eslint-scope": {
"version": "5.1.1",
"resolved": "https://registry.npmjs.org/eslint-scope/-/eslint-scope-5.1.1.tgz",
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 986502daff7..7fac1a874f2 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -260,6 +260,9 @@
"@storybook/addon-links": "10.5.10",
"@storybook/react-webpack5": "10.5.10",
"@storybook/test-runner": "0.24.4",
+ "@superset-ui/eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
+ "@superset-ui/eslint-plugin-icons": "file:eslint-rules/eslint-plugin-icons",
+ "@superset-ui/eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
"@svgr/webpack": "^8.1.0",
"@swc/core": "^1.16.1",
"@swc/plugin-emotion": "^15.0.0",
@@ -303,8 +306,6 @@
"eslint": "^10.9.0",
"eslint-import-resolver-alias": "^1.1.2",
"eslint-import-resolver-typescript": "^4.4.5",
- "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
- "eslint-plugin-icons": "file:eslint-rules/eslint-plugin-icons",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jest-dom": "^5.10.1",
"eslint-plugin-lodash": "^8.0.0",
@@ -313,7 +314,6 @@
"eslint-plugin-react-you-might-not-need-an-effect": "^1.0.2",
"eslint-plugin-storybook": "10.5.10",
"eslint-plugin-testing-library": "^7.16.2",
- "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
"fetch-mock": "^12.6.0",
"fork-ts-checker-webpack-plugin": "^9.1.0",
"history": "^5.3.0",